rm: CI LUKS encryption#768
Merged
kprosise merged 2 commits intofoundriesio:mainfrom Nov 7, 2024
Merged
Conversation
Following foundriesio/meta-lmp#1530, we now allow users to define their own passphrases for CI LUKS encryption. Signed-off-by: Jorge Ramirez-Ortiz <[email protected]>
Member
kprosise
approved these changes
Nov 5, 2024
Contributor
kprosise
left a comment
There was a problem hiding this comment.
Just a one suggestions with minor changes. Otherwise it LGTM.
Co-authored-by: Katrina Prosise <[email protected]>
Member
MrCry0
approved these changes
Nov 5, 2024
angolini
approved these changes
Nov 7, 2024
Contributor
Author
|
@kprosise jfyi |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following foundriesio/meta-lmp#1530, we now allow users to define their own passphrases for CI LUKS encryption.
PR Template and Checklist
Please complete as much as possible to speed up the reviewing process.
Readiness and adding reviewers as appropriate is required.
All PRs should be reviewed by a technical writer/documentation team and a peer.
If effecting customers—which is a majority of content changes—a member of Customer Success must also review.
Readiness
Overview
Why merge this PR? What does it solve?
Checklist
make linkcheck.-s, --signoff).-S, --gpg-sign).Comments
Any thing else that a maintainer/reviewer should know.
This could include potential issues, rational for approach, etc.