containers: Handle advanced tagging for prebuilt images#136
Merged
doanac merged 1 commit intofoundriesio:masterfrom Jun 21, 2021
Merged
containers: Handle advanced tagging for prebuilt images#136doanac merged 1 commit intofoundriesio:masterfrom
doanac merged 1 commit intofoundriesio:masterfrom
Conversation
mike-sul
approved these changes
Jun 21, 2021
Contributor
|
I am not sure I fully understand the issue and the approach to fix it but the change/code LGTM. |
If you have a container build producing targets based on multiple platforms we were using the same file name and overwriting the work we'd done. Signed-off-by: Andy Doan <[email protected]>
Member
Author
|
rebased on master |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If you have a container build producing targets based on multiple
platforms we were using the same file name and overwriting the work we'd
done.
Signed-off-by: Andy Doan [email protected]