Initial prototype of OSTree-based Compose Apps#110
Initial prototype of OSTree-based Compose Apps#110mike-sul merged 13 commits intofoundriesio:masterfrom
Conversation
c424a07 to
ed3c624
Compare
|
@doanac effectively this is the implementation of item #1.1 of the implementation plan https://docs.google.com/document/d/1lQs5Sas0WwVFzcaH4v-UYelgvaYn6_PBkEGs-Ndop5I/edit#heading=h.e4bsxuh2k3zs Part 1.2 foundriesio/meta-lmp#240 I think it can even be deployed without impacting existing devices and customers, just the container job (publish run) will take a bit longer and an ostree repo will be used for the preloading. |
852fd28 to
946845b
Compare
589c2db to
97fd8e7
Compare
|
@doanac This is an implementation of part 1.1 and 1.2 of the implementation plan https://docs.google.com/document/d/1lQs5Sas0WwVFzcaH4v-UYelgvaYn6_PBkEGs-Ndop5I/edit#heading=h.e4bsxuh2k3zs. I tested basic use-cases and I think it's good enough for review and dev testing. |
| --targets-file "${TUF_REPO}/roles/unsigned/targets.json" \ | ||
| --targets-to-publish "${ARCHIVE}/targets-created.json" \ | ||
| --fetch-dir "${PRELOAD_DIR}" \ | ||
| --repo-dir "${OSTREE_REPO_DIR}" |
There was a problem hiding this comment.
Should we make this configurable/optional for now? Or maybe we go all-in and avoid making us all do factory-config changes to try?
There was a problem hiding this comment.
It doesn't require any changes to factory-config to try it out, those params have default definition at the beginning of the script.
There was a problem hiding this comment.
but since its not optional, this means that all factories will start producing this new content once merged, correct?
There was a problem hiding this comment.
yes, what should not impact their existing workflow. We can make it optional, but then another question arises - how to do preload?
There was a problem hiding this comment.
so, I am making it OFF by default, just do exactly as it does now, COMPOSE_APP_USE_OSTREE set in factory-config.yml turns the ostree usage ON.
The only question is in regard to 'fioctl target image' command since it doesn't have access to factory-config.yml.
|
I need to rebase it on the latest master and then retest it again. |
97fd8e7 to
ca26aed
Compare
ca26aed to
ccc9382
Compare
d22ab0d to
f8b4acc
Compare
Signed-off-by: Mike Sul <[email protected]>
Signed-off-by: Mike Sul <[email protected]>
Signed-off-by: Mike Sul <[email protected]>
Signed-off-by: Mike Sul <[email protected]>
Signed-off-by: Mike Sul <[email protected]>
It turned out that it's possible to refer to an ostree commit by specifying both a branch and a commit hash in a single URI. If such composite URI is specified to `ostree pull` command then the ostree repo will update corresponding ref automaticaly so it points to the commit that has been pulled. Signed-off-by: Mike Sul <[email protected]>
Signed-off-by: Mike Sul <[email protected]>
Signed-off-by: Mike Sul <[email protected]>
Signed-off-by: Mike Sul <[email protected]>
Simultaneous support of the current non-ostree based apps preloading and an ostree based apps, the later supports/implies the preloading support by default. Signed-off-by: Mike Sul <[email protected]>
Make sure that files stored in the apps' ostree repo are checked out by using hardlinks. Signed-off-by: Mike Sul <[email protected]>
f8b4acc to
3b61862
Compare
Signed-off-by: Mike Sul <[email protected]>
8277400 to
95d3cd4
Compare
Signed-off-by: Mike Sul <[email protected]>
95d3cd4 to
650f0c8
Compare
No description provided.