suggestions for executable definitions PR#1
Closed
yaacovCR wants to merge 2 commits intofotoetienne:executableDescriptions2025from
Closed
suggestions for executable definitions PR#1yaacovCR wants to merge 2 commits intofotoetienne:executableDescriptions2025from
yaacovCR wants to merge 2 commits intofotoetienne:executableDescriptions2025from
Conversation
1. consolidate some logic 2. ensure that the "unexpected description" error for unknown keywords surfaces rather than the "unexpected keyword" error itself, as the description occurs first!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
see: graphql#4430
first commit is just to reduce diff with graphql-js/16.x.x i.e. the overall PR diff, while preserving full code coverage
second commit tweaks response to the feedback on that PR (graphql#4430 (comment))
i.e. the behavior when there is an unexpected description preceding an unexpected keyword. The existing behavior on 16.x.x is to surface the error for the description, which occurs first, this tweak preserves that behavior, adding a test.