Skip to content

Add on to the mitigation in https://github.com/visionmedia/supertest/…#735

Merged
niftylettuce merged 1 commit into
forwardemail:masterfrom
benjosantony:master
Aug 17, 2021
Merged

Conversation

@benjosantony

Copy link
Copy Markdown
Contributor

Add on to the mitigation in https://github.com/visionmedia/supertest/pull/728/commits.

  • As [].every(val => typeof val === 'number')) evaluates to true in legit cases where we expect the body to return empty array the tests will fail.
  • Change is to also check for array length and defaulting to consider it as body instead of empty list of statues.

@niftylettuce niftylettuce merged commit 28116f9 into forwardemail:master Aug 17, 2021
@niftylettuce

Copy link
Copy Markdown
Collaborator

v6.1.6 released

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants