Send unicast to selected peer, have windows see multiple instances (and pass the new discovery tests) by ldemailly · Pull Request #19 · fortio/tsync

ldemailly · 2025-10-22T04:04:28Z

No description provided.

…t WARP.md yet

codecov · 2025-10-22T04:05:14Z

Codecov Report

❌ Patch coverage is 78.09524% with 23 lines in your changes missing coverage. Please review.
✅ Project coverage is 54.59%. Comparing base (12564c1) to head (ab2c450).
⚠️ Report is 1 commits behind head on main.

Files with missing lines	Patch %	Lines
tsnet/tsnet.go	82.00%	13 Missing and 5 partials ⚠️
main.go	0.00%	5 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff             @@
##             main      #19       +/-   ##
===========================================
+ Coverage   32.75%   54.59%   +21.83%     
===========================================
  Files           9        9               
  Lines         693      784       +91     
===========================================
+ Hits          227      428      +201     
+ Misses        458      314      -144     
- Partials        8       42       +34

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copilot

Pull Request Overview

This PR implements unicast messaging to enable direct peer-to-peer connections after multicast discovery. The changes introduce a connection management system where peers can initiate direct UDP connections to each other, supplementing the existing multicast discovery mechanism.

Key Changes:

Added unicast receiver alongside multicast for handling direct peer connections
Implemented connection request/response protocol with connection state tracking
Created comprehensive test suite for peer discovery and multi-peer scenarios

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.

File	Description
tsnet/tsnet.go	Core implementation of unicast messaging, connection management, and protocol message formats
tsnet/tsnet_test.go	New test file with peer discovery and multi-peer connection tests
main.go	Integration of ConnectToPeer functionality with user input
WARP.md	Documentation update describing the new connection capabilities

Comments suppressed due to low confidence (1)

tsnet/tsnet.go:1

Variable shadowing: expected is declared twice in this test function (lines 185 and 209), which could lead to confusion. The second declaration should use a different name like expectedPeers.

// Package tsnet is the network library support for tsync (discovery/registration and communication).

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

tsnet/tsnet_test.go

tsnet/tsnet.go

Copilot

Pull Request Overview

Copilot reviewed 5 out of 6 changed files in this pull request and generated 2 comments.

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

tsnet/tsnet.go

Copilot

Pull Request Overview

Copilot reviewed 5 out of 6 changed files in this pull request and generated 2 comments.

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

tsnet/tsnet.go

Copilot

Pull Request Overview

Copilot reviewed 5 out of 6 changed files in this pull request and generated 2 comments.

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

tsnet/tsnet.go

Copilot · 2025-10-22T05:27:48Z

tsnet/tsnet.go

+	AcceptMessageFormat    = "accept1 %q"        // target_name
+	RejectMessageFormat    = "reject1 %q %q"     // target_name, reason
+	DataMessageFormat      = "data1 %q %s"       // target_name, signed_data


Several message formats (AcceptMessageFormat, RejectMessageFormat, DataMessageFormat) are defined but never used in the codebase. Consider removing unused constants or implementing the corresponding message handlers if they're planned for future use.

Suggested change

AcceptMessageFormat = "accept1 %q" // target_name

RejectMessageFormat = "reject1 %q %q" // target_name, reason

DataMessageFormat = "data1 %q %s" // target_name, signed_data

will add that later

Copilot

Pull Request Overview

Copilot reviewed 5 out of 6 changed files in this pull request and generated 1 comment.

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

tsnet/tsnet_test.go

Copilot

Pull Request Overview

Copilot reviewed 5 out of 6 changed files in this pull request and generated 1 comment.

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

tsnet/tsnet.go

ldemailly added 4 commits October 21, 2025 17:28

Adding WARP info even though we haven't use it to do anything but tha…

7058b5c

…t WARP.md yet

WIP connection code + discovery tests

1e1e9f1

Snapshot - sort of works except hangs in Stop

42e81a9

Fix the hang

4b06e23

ldemailly added 4 commits October 21, 2025 21:14

clean up and clarity

b5aa665

no fixed time for discovery

bf028c8

Skip mcast on mac CI

8e3ec99

Well windows too

99264e9

ldemailly requested a review from Copilot October 22, 2025 04:45

Copilot AI reviewed Oct 22, 2025

View reviewed changes

tsnet/tsnet_test.go Outdated Show resolved Hide resolved

tsnet/tsnet.go Outdated Show resolved Hide resolved

ldemailly added 3 commits October 21, 2025 21:55

trying to fix multiple process, on windows

5c2e045

trying again windows on ci

1112349

Fix lints

81e8752

ldemailly requested a review from Copilot October 22, 2025 05:08

ldemailly changed the title ~~Send unicast to selected peer~~ Send unicast to selected peer, have windows see multiple instances (and pass the new discovery tests) Oct 22, 2025

Copilot AI reviewed Oct 22, 2025

View reviewed changes

tsnet/tsnet.go Outdated Show resolved Hide resolved

tsnet/tsnet.go Outdated Show resolved Hide resolved

comment fixes

dda6c79

ldemailly requested a review from Copilot October 22, 2025 05:11

Copilot AI reviewed Oct 22, 2025

View reviewed changes

tsnet/tsnet.go Outdated Show resolved Hide resolved

tsnet/tsnet.go Outdated Show resolved Hide resolved

Replace the 2 equal sockets by 1 socket

94dbc7f

ldemailly requested a review from Copilot October 22, 2025 05:27

Copilot AI reviewed Oct 22, 2025

View reviewed changes

Drop the extra 'connection' and reuse the socket

880c1bb

ldemailly requested a review from Copilot October 22, 2025 05:37

Copilot AI reviewed Oct 22, 2025

View reviewed changes

tsnet/tsnet_test.go Outdated Show resolved Hide resolved

remove duplicate

ab2c450

ldemailly requested a review from Copilot October 22, 2025 05:42

Copilot AI reviewed Oct 22, 2025

View reviewed changes

tsnet/tsnet.go Show resolved Hide resolved

ldemailly merged commit 5b33b38 into main Oct 22, 2025
9 checks passed

ldemailly deleted the conn8 branch October 22, 2025 05:49

	AcceptMessageFormat = "accept1 %q" // target_name
	RejectMessageFormat = "reject1 %q %q" // target_name, reason
	DataMessageFormat = "data1 %q %s" // target_name, signed_data

Conversation

ldemailly commented Oct 22, 2025

Uh oh!

codecov bot commented Oct 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Uh oh!

Uh oh!

Copilot AI Oct 22, 2025

Choose a reason for hiding this comment

Uh oh!

ldemailly Oct 22, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

codecov bot commented Oct 22, 2025 •

edited

Loading