Skip to content

Fix for empty ts name when tailscale isn't running on windows#370

Merged
ldemailly merged 3 commits intomainfrom
ts_exit
Jan 26, 2026
Merged

Fix for empty ts name when tailscale isn't running on windows#370
ldemailly merged 3 commits intomainfrom
ts_exit

Conversation

@ldemailly
Copy link
Copy Markdown
Member

fixes #369

on windows we get empty self name (while on macos we get a connection error instead)

@codecov
Copy link
Copy Markdown

codecov bot commented Jan 26, 2026

Codecov Report

❌ Patch coverage is 0% with 10 lines in your changes missing coverage. Please review.
✅ Project coverage is 13.87%. Comparing base (4e2cd83) to head (ec21b31).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
config/tailscale.go 0.00% 8 Missing ⚠️
proxy_main.go 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #370      +/-   ##
==========================================
- Coverage   14.33%   13.87%   -0.46%     
==========================================
  Files           4        4              
  Lines         272      281       +9     
==========================================
  Hits           39       39              
- Misses        231      240       +9     
  Partials        2        2              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ldemailly ldemailly merged commit 0aa3396 into main Jan 26, 2026
7 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

when tailscale is not running and -tailscale is passed the proxy just dies silently

2 participants