Skip to content

Fix linter issues from fortio/cli 1.12.3 upgrade#181

Merged
ldemailly merged 2 commits intodependabot/go_modules/fortio.org/cli-1.12.3from
copilot/sub-pr-180
Nov 11, 2025
Merged

Fix linter issues from fortio/cli 1.12.3 upgrade#181
ldemailly merged 2 commits intodependabot/go_modules/fortio.org/cli-1.12.3from
copilot/sub-pr-180

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Nov 11, 2025

The dependency bump to fortio.org/cli 1.12.3 triggered 3 linter violations with golangci-lint v2.6.1.

Fixes:

  • godoclint: Package comment now starts with "Package mc" per Go conventions
  • noctx: Port lookup now uses net.DefaultResolver.LookupPort(ctx, ...) instead of context-free net.LookupPort()
  • staticcheck: Boolean expression simplified via De Morgan's law: !(*ipv4 && *ipv6)!*ipv4 || !*ipv6
// Before
cfg.portNum, err = net.LookupPort("tcp", cfg.port)

// After
cfg.portNum, err = net.DefaultResolver.LookupPort(ctx, "tcp", cfg.port)

💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

Copilot AI changed the title [WIP] Update fortio.org/cli from 1.12.1 to 1.12.3 Fix linter issues from fortio/cli 1.12.3 upgrade Nov 11, 2025
Copilot AI requested a review from ldemailly November 11, 2025 21:33
@ldemailly ldemailly marked this pull request as ready for review November 11, 2025 21:41
@ldemailly ldemailly merged commit b41cadf into dependabot/go_modules/fortio.org/cli-1.12.3 Nov 11, 2025
@ldemailly ldemailly deleted the copilot/sub-pr-180 branch November 11, 2025 21:42
ldemailly added a commit that referenced this pull request Nov 11, 2025
… from 1.12.1 to 1.12.3 (#180)

* Bump fortio.org/cli from 1.12.1 to 1.12.3

Bumps [fortio.org/cli](https://github.com/fortio/cli) from 1.12.1 to 1.12.3.
- [Release notes](https://github.com/fortio/cli/releases)
- [Commits](fortio/cli@v1.12.1...v1.12.3)

---
updated-dependencies:
- dependency-name: fortio.org/cli
  dependency-version: 1.12.3
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>

* Fix linter issues from fortio/cli 1.12.3 upgrade (#181)

* Initial plan

* Fix linter issues: godoclint, noctx, and staticcheck

Co-authored-by: ldemailly <[email protected]>

---------

Co-authored-by: copilot-swe-agent[bot] <[email protected]>
Co-authored-by: ldemailly <[email protected]>

* update progressbar too while at it

* fix go.sum

* Fix tests for json format

---------

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Copilot <[email protected]>
Co-authored-by: ldemailly <[email protected]>
Co-authored-by: Laurent Demailly <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants