Repository navigation
Commit 26fe7ad
authored
ci: check all features with Clippy (apache#26591)
## Which issue does this PR close?
Related to apache#26181 and the [CI follow-up requested in
apache#26189](apache#26189 (comment)).
## Rationale for this change
The existing Clippy feature set missed the Arrow buffer-pool lint
failures exposed by `--all-features`. Run both configurations through
the shared script so CI, local developers, and agents get the same
checks.
Keep the existing feature set: `force_hash_collisions` excludes normal
hashing code when all features are enabled.
## What changes are included in this PR?
- Run the existing feature-specific check followed by the all-features
check in `ci/scripts/rust_clippy.sh`.
- Apply `--write` and `--allow-dirty` consistently to both passes,
retaining the clean-worktree guard and failure propagation.
- Install CMake before invoking the script in CI, because the
all-features build includes `snmalloc-sys`.
## What is the testing strategy for this PR?
- `cargo fmt --all` and `git diff --check` pass.
- Both Clippy passes in `ci/scripts/rust_clippy.sh` pass, as does `cargo
clippy --all-targets --all-features -- -D warnings`.
- The full `uv run ./dev/rust_lint.sh` suite passes, including the
workflow validators and 28 workflow tests.
- Ten shell behavior probes cover both configurations, write mode, the
dirty-worktree guard, and failure propagation. A disposable Rust crate
also verifies real fixes in both feature configurations, rejection of an
initially dirty worktree, and `--allow-dirty` support.
- The required extended workspace test command passes: 12,899 Rust tests
and all 541 SQL logic test files; eight Rust tests are ignored.
All validation above was run locally. Hosted CI must rerun for the
updated head.
## Are there any user-facing changes?
Local `rust_clippy.sh` and `dev/rust_lint.sh` runs now check both
feature configurations. The all-features build requires CMake to be
installed locally. No SQL behavior or public API changes.1 parent 1e6017c commit 26fe7ad
2 files changed
Lines changed: 14 additions & 9 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
835 | 835 | | |
836 | 836 | | |
837 | 837 | | |
| 838 | + | |
| 839 | + | |
| 840 | + | |
838 | 841 | | |
839 | 842 | | |
840 | 843 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
22 | 22 | | |
23 | 23 | | |
24 | 24 | | |
25 | | - | |
| 25 | + | |
26 | 26 | | |
27 | 27 | | |
28 | 28 | | |
| |||
34 | 34 | | |
35 | 35 | | |
36 | 36 | | |
37 | | - | |
| 37 | + | |
38 | 38 | | |
39 | 39 | | |
40 | 40 | | |
| |||
65 | 65 | | |
66 | 66 | | |
67 | 67 | | |
68 | | - | |
69 | | - | |
70 | | - | |
71 | | - | |
| 68 | + | |
72 | 69 | | |
73 | | - | |
74 | 70 | | |
75 | | - | |
76 | | - | |
| 71 | + | |
| 72 | + | |
| 73 | + | |
| 74 | + | |
| 75 | + | |
| 76 | + | |
| 77 | + | |
| 78 | + | |
0 commit comments