Skip to content

fix: Oveview Page Redirect and Contributing Section Redirects Links… - #3365

Merged
mattinannt merged 2 commits into
formbricks:mainfrom
iamitpal:bug/broken-redirects-on-developer-docs-updated
Oct 11, 2024
Merged

mattinannt merged 2 commits into
formbricks:mainfrom
iamitpal:bug/broken-redirects-on-developer-docs-updated

Conversation

@iamitpal

@iamitpal iamitpal commented Oct 10, 2024 •

Copy link
Copy Markdown
Contributor

What does this PR do?

I updated the Oveview Page Redirect and Contributing Section Redirects Links in Developer docs.3344

Fixes #3344

Screenshot 2024-10-10 at 7 05 02 PM

How should this be tested?

  • Go to formbricks.com -> docs -> developer-docs ->under overview -> click on "Contributing to Formbricks"
  • Go to formbricks.com -> docs -> developer-docs -> Contributing -> under getting started -> click on "Gitpod" and "GitHub Codespaces"

Checklist

Required

  • Filled out the "How to test" section in this PR
  • Read How we Code at Formbricks
  • Self-reviewed my own code
  • Commented on my code in hard-to-understand bits
  • Ran pnpm build
  • Checked for warnings, there are none
  • Removed all console.logs
  • Merged the latest changes from main onto my branch with git pull origin main
  • My changes don't cause any responsiveness issues
  • First PR at Formbricks? Please sign the CLA! Without it we wont be able to merge it 🙏

Appreciated

  • If a UI change was made: Added a screen recording or screenshots to this PR
  • Updated the Formbricks Docs if changes were necessary

Summary by CodeRabbit

  • Documentation
    • Updated metadata for clarity in the contributing guide.
    • Corrected links for setting up the development environment.
    • Enhanced guidance on contributing to Formbricks with specific paths.

@vercel

vercel Bot commented Oct 10, 2024

Copy link
Copy Markdown

@iamitpal is attempting to deploy a commit to the formbricks Team on Vercel.

A member of the Team first needs to authorize it.

@coderabbitai

coderabbitai Bot commented Oct 10, 2024 •

Copy link
Copy Markdown
Contributor

Walkthrough

The changes in this pull request involve updates to the documentation files for the Formbricks project. Specifically, the page.mdx files for both the "Get Started" and "Overview" sections have been modified to correct links related to contributing and setting up the development environment. The metadata in the "Get Started" page has been refined for clarity, while the link structure has been adjusted to ensure proper navigation without broken redirects.

Changes

File Path Change Summary
apps/docs/app/developer-docs/contributing/get-started/page.mdx Updated metadata for title and description; corrected links for Gitpod and Codespaces setup.
apps/docs/app/developer-docs/overview/page.mdx Updated the link in the "Contributing to Formbricks" section to point to the more specific path.

Possibly related issues

Possibly related PRs

Suggested labels

bug, enhancement, 🕹️ oss.gg

Poem

🐇 In the docs where rabbits hop,
Links were broken, but now they stop.
With paths corrected, clear and bright,
Contributors gather, ready to write!
Hooray for changes, let’s all cheer,
For Formbricks’ docs, we hold so dear! 🌟


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@github-actions

github-actions Bot commented Oct 10, 2024 •

Copy link
Copy Markdown
Contributor

Thank you for following the naming conventions for pull request titles! 🙏

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🧹 Outside diff range and nitpick comments (1)
apps/docs/app/developer-docs/contributing/get-started/page.mdx (1)

Line range hint 1-190: Overall: Documentation improvements enhance contributor experience.

The changes made to this file effectively address the PR objectives by updating the metadata for better engagement and fixing redirect issues in the contributing documentation. These improvements will enhance the experience for new contributors and align with the goal of maintaining clear and accessible documentation.

A few suggestions for further improvement:

  1. Consider adding a table of contents at the beginning of the document for easier navigation.
  2. Review the "Setup Dev Environment" section to ensure it's up-to-date with the latest development practices.
  3. Add a section on code style and formatting expectations to maintain consistency across contributions.
🧰 Tools
🪛 LanguageTool

[uncategorized] ~41-~41: Possible missing comma found.
Context: ...er** to explore and develop. For junior developers we suggest using either of these, becau...

(AI_HYDRA_LEO_MISSING_COMMA)


[formatting] ~41-~41: If the ‘because’ clause is essential to the meaning, do not use a comma before the clause.
Context: ...elopers we suggest using either of these, because you can dive into coding within minutes...

(COMMA_BEFORE_BECAUSE)

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Files that changed from the base of the PR and between a6a815c and da1f5eb.

📒 Files selected for processing (2)
  • apps/docs/app/developer-docs/contributing/get-started/page.mdx (1 hunks)
  • apps/docs/app/developer-docs/overview/page.mdx (1 hunks)
✅ Files skipped from review due to trivial changes (1)
  • apps/docs/app/developer-docs/overview/page.mdx
🧰 Additional context used
🔇 Additional comments (1)
apps/docs/app/developer-docs/contributing/get-started/page.mdx (1)

Line range hint 3-7: LGTM: Metadata updates improve clarity and engagement.

The updated title and description in the metadata provide a more comprehensive and engaging overview of the contribution process. These changes align well with the document's content and should improve SEO and user understanding.

🧰 Tools
🪛 LanguageTool

[uncategorized] ~41-~41: Possible missing comma found.
Context: ...er** to explore and develop. For junior developers we suggest using either of these, becau...

(AI_HYDRA_LEO_MISSING_COMMA)


[formatting] ~41-~41: If the ‘because’ clause is essential to the meaning, do not use a comma before the clause.
Context: ...elopers we suggest using either of these, because you can dive into coding within minutes...

(COMMA_BEFORE_BECAUSE)

Comment on lines +37 to +38
- [Gitpod](/developer-docs/contributing/gitpod)
- [GitHub Codespaces](/developer-docs/contributing/codespaces)

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codebase verification

Issue Found: Remaining absolute paths detected.

While the links in apps/docs/app/developer-docs/contributing/get-started/page.mdx have been corrected to relative paths, there are still absolute links present in CONTRIBUTING.md:

  • CONTRIBUTING.md:1 contains absolute paths to Gitpod and Codespaces.

Please update these links to use relative paths to ensure consistent navigation within the documentation.

🔗 Analysis chain

LGTM: Link corrections resolve redirect issues.

The updated links for Gitpod and GitHub Codespaces now use relative paths, which should resolve the redirect issues mentioned in the PR objectives. This change improves the navigation within the developer documentation.

To ensure these links are working correctly, please run the following verification script:

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Verify the existence of the linked pages and check for any remaining absolute paths.

# Test 1: Check if the linked pages exist
fd -e mdx -p "developer-docs/contributing/(gitpod|codespaces)" || echo "Error: One or both of the linked pages are missing."

# Test 2: Search for any remaining absolute paths to these pages
rg "/docs/developer-docs/contributing/(gitpod|codespaces)" || echo "No absolute paths found."

Length of output: 477

@mattinannt mattinannt changed the title Bug Fix: Oveview Page Redirect and Contributing Section Redirects Links… fix: Oveview Page Redirect and Contributing Section Redirects Links… Oct 11, 2024
@mattinannt

Copy link
Copy Markdown
Member

@iamitpal Thanks a lot for raising a PR for this but the issue creator already solved the issue himself. #3343

@mattinannt mattinannt closed this Oct 11, 2024
@mattinannt mattinannt reopened this Oct 11, 2024
@mattinannt
mattinannt merged commit 6761452 into formbricks:main Oct 11, 2024
@oss-gg

oss-gg Bot commented Oct 11, 2024

Copy link
Copy Markdown

Awarding iamitpal: 150 points 🕹️ Well done! Check out your new contribution on oss.gg/iamitpal

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] Broken Redirects on Developer Docs -> Contributing Page

2 participants