Skip to content

fix: Error in Docs navigation #1518#1521

Merged
mattinannt merged 1 commit intoformbricks:mainfrom
bilalmirza74:main
Oct 30, 2023
Merged

fix: Error in Docs navigation #1518#1521
mattinannt merged 1 commit intoformbricks:mainfrom
bilalmirza74:main

Conversation

@bilalmirza74
Copy link
Copy Markdown
Contributor

@bilalmirza74 bilalmirza74 commented Oct 30, 2023

What does this PR do?

Fixes #1518

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Chore (refactoring code, technical debt, workflow improvements)
  • Enhancement (small improvements)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change adds a new database migration
  • This change requires a documentation update

How should this be tested?

  • Test A
  • Test B

Checklist

Required

  • Filled out the "How to test" section in this PR
  • Read How we Code at Formbricks
  • Self-reviewed my own code
  • Commented on my code in hard-to-understand bits
  • Ran pnpm build
  • Checked for warnings, there are none
  • Removed all console.logs
  • Merged the latest changes from main onto my branch with git pull origin main
  • My changes don't cause any responsiveness issues
  • First PR at Formbricks? Please sign the CLA! Without it we wont be able to merge it 🙏

Appreciated

  • If a UI change was made: Added a screen recording or screenshots to this PR
  • Updated the Formbricks Docs if changes were necessary

@vercel
Copy link
Copy Markdown

vercel bot commented Oct 30, 2023

@bilalmirza74 is attempting to deploy a commit to the formbricks Team on Vercel.

A member of the Team first needs to authorize it.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Oct 30, 2023

Thank you for following the naming conventions for pull request titles! 🙏

@github-actions github-actions bot added the bug Something isn't working label Oct 30, 2023
@review-agent-prime
Copy link
Copy Markdown
Contributor

review-agent-prime bot commented Oct 30, 2023

The PR seems to be removing the "From Source" link from the "Self-hosting" section. If this is intentional and the corresponding documentation page has been removed or deprecated, then the change is fine.

However, if the "From Source" page still exists and is relevant, consider adding it back to the navigation:

{
  title: "Self-hosting",
  links: [
    { title: "Deployment", href: "/docs/self-hosting/deployment" },
    { title: "Production", href: "/docs/self-hosting/production" },
    { title: "Docker", href: "/docs/self-hosting/docker" },
+   { title: "From Source", href: "/docs/self-hosting/from-source" },
    { title: "Migration Guide", href: "/docs/self-hosting/migration-guide" },
  ],
},

Please ensure that any changes to the navigation reflect the actual content and structure of the documentation.

@bilalmirza74 bilalmirza74 mentioned this pull request Oct 30, 2023
Closed
2 tasks
mattinannt
mattinannt approved these changes Oct 30, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@mattinannt mattinannt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙏

@mattinannt mattinannt added this pull request to the merge queue Oct 30, 2023
Merged via the queue into formbricks:main with commit c42d48e Oct 30, 2023
kevinkong91 added a commit to kevinkong91/formbricks that referenced this pull request Oct 30, 2023
@kevinkong91
Merge branch 'main' into dev
3f28fac 
* main: (28 commits)
  chore: Add Table of Contents to README (formbricks#1427)
  fix: account deletion failing issue (formbricks#1509)
  fix: remove welcome card from email preview (formbricks#1495)
  fix(bug): default role implemented (formbricks#1524)
  fix: changing description of Code Action (formbricks#1522)
  refactor: Migrate activity service (formbricks#1471)
  fix: Error in Docs navigation formbricks#1518 (formbricks#1521)
  feat: dynamic title and description (formbricks#1459)
  fix: Spelling Errors (formbricks#1517)
  fix: added scrollbar whenever overflowed in the settings/profile page (formbricks#1498)
  fix: long url not getting reset after closing modal (formbricks#1502)
  fix: Unexpected Behavior when Toggling Italics in Text Editor and improve clarity of formatting status (formbricks#1506)
  fix: zod pin validation failing (formbricks#1507)
  fix: Error message on Login not shown  (formbricks#1508)
  fix: downgrade nextjs to fix error with react email (formbricks#1516)
  chore: downgrade next version in formbricks-com (formbricks#1513)
  feat: picture selection question (formbricks#1388)
  feat: formtribe leaderboard update as per today (formbricks#1505)
  fix: Added if statement for preventing use of reserved word in question ID (formbricks#1435)
  fix: Disabling Welcome Card leads buggy preview (formbricks#1320)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mattinannt mattinannt mattinannt approved these changes

Assignees

No one assigned

Labels

bug Something isn't working hacktoberfest-accepted

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[BUG] Error in Docs navigation

2 participants

@bilalmirza74 @mattinannt