feat: add image/color/animation as survey background#1515
feat: add image/color/animation as survey background#1515mattinannt merged 59 commits intoformbricks:mainfrom
Conversation
|
@anjy7 is attempting to deploy a commit to the formbricks Team on Vercel. A member of the Team first needs to authorize it. |
|
Thank you for following the naming conventions for pull request titles! 🙏 |
|
Hi @anjy7, thank you for your contribution. I tested this feature on local and faced two issues,
Screen.Recording.2023-10-31.at.2.44.38.PM.movcc: @mattinannt |
|
|
Heyy @neilchauhan2, I have fixed both the issues, please have a look - |
|
@neilchauhan2 passing it back to you :) I've solved most of the UI / UX issues, except for one: content position of images:
Task 1: Center the background image in the frame vertically and horizontally.. Code Review We have quite some redundant code in:
Task 2: Please refactor so that it is reusable and follows the DRY principle. Task 3: Apart from that, please go through the complete PR and see if you notice anything else which deviates from our How we code at Formbricks best practices. Task 4: Make a complete end-to-end test of the UI & UX. Catch all the bugs / inconsistencies which could arise with other link survey functionality. Thanks 🙏 |
|
whats missing is to refactor Merge conflicts |
|
@mattinannt allllllrighty, seems all good! It works well, just getting a build error but dont think its related to my refactoring:
Pls resolve and merge 🚀 |
|
Just updated the data model and added a more generic |
|
Lets gooooo!!💪🏻🔥 |


What does this PR do?
Fixes #1444
Loom Video: https://www.loom.com/share/3650caac8e4c43c098a645b309b10665?sid=85821dd8-7725-4140-8a18-47093197425a
Type of change
How should this be tested?
Checklist
Required
pnpm buildconsole.logsgit pull origin mainAppreciated