The latest updates on your projects. Learn more about Vercel for Git ↗︎

Thank you for following the naming conventions for pull request titles! 🙏

Overall, the changes in this PR look good. However, there are a few areas where improvements can be made:

1. In EditWelcomeCard.tsx, the onChange event handler for the Switch component is directly modifying the timeToFinish property of the welcomeCard object. It would be better to create a new object with the updated property to avoid mutating the state directly. Here's a suggested change:

onCheckedChange={() =>
  updateSurvey({ ...localSurvey, welcomeCard: { ...localSurvey.welcomeCard, timeToFinish: !localSurvey.welcomeCard.timeToFinish } })
}

2. In ProgressBar.tsx, the calculateProgress function has been simplified by extracting the logic for calculating elementIdx into a separate function calculateElementIdx. This is a good practice as it improves code readability and maintainability. However, it would be better to handle the case where calculateElementIdx returns undefined or null.

3. In WelcomeCard.tsx, the calculateTimeToComplete function assumes that each question takes 15 seconds to complete. This might not always be the case. It would be better to make this a configurable parameter.

4. In utils.ts, the calculateElementIdx function has a fallback value of 0.5 for elementIdx when currentQustionIdx is undefined or null. It would be better to handle these edge cases explicitly.

5. In surveys.ts, the default value of timeToFinish has been changed from false to true. This is a significant change that could affect the behavior of existing surveys. Please ensure that this change is intended and that it has been thoroughly tested.