feat: picture selection question#1388
Conversation
|
@gupta-piyush19 is attempting to deploy a commit to the formbricks Team on Vercel. A member of the Team first needs to authorize it. |
|
Thank you for following the naming conventions for pull request titles! 🙏 |
|
The PR looks good overall, but there are a few areas that could be improved:
Here are the suggested changes: // PictureSelectionForm.tsx
// Remove unused function
// const updateSurvey = (prop) => {
// // updateQuestion(questionIdx, updatedAttributes);
// };
// FileInput/index.tsx
// Stop function execution when not all files are allowed
if (areAllFilesAllowed) {
// ...
} else {
toast.error("Files not supported");
return;
}
// LinkSurvey.tsx
// Remove unused state
// const [source, setSource] = useState<string>("");
// FileInput/index.tsx
// Remove unused function
// const handleRemove = async (idx: number) => {
// const newFileUrl = fileUrl?.filter((_, i) => i !== idx);
// onFileUpload(newFileUrl);
// };Please consider these suggestions and apply them if they make sense in your context. |
pandeymangg
left a comment
There was a problem hiding this comment.
Thanks a lot for the PR @gupta-piyush19 ! Looks and works great 🥳
Just left a few comments, after that we can merge this 😊
|
from my side, it's good to go :) @pandeymangg merge when you approve my changes |
* main: (28 commits) chore: Add Table of Contents to README (formbricks#1427) fix: account deletion failing issue (formbricks#1509) fix: remove welcome card from email preview (formbricks#1495) fix(bug): default role implemented (formbricks#1524) fix: changing description of Code Action (formbricks#1522) refactor: Migrate activity service (formbricks#1471) fix: Error in Docs navigation formbricks#1518 (formbricks#1521) feat: dynamic title and description (formbricks#1459) fix: Spelling Errors (formbricks#1517) fix: added scrollbar whenever overflowed in the settings/profile page (formbricks#1498) fix: long url not getting reset after closing modal (formbricks#1502) fix: Unexpected Behavior when Toggling Italics in Text Editor and improve clarity of formatting status (formbricks#1506) fix: zod pin validation failing (formbricks#1507) fix: Error message on Login not shown (formbricks#1508) fix: downgrade nextjs to fix error with react email (formbricks#1516) chore: downgrade next version in formbricks-com (formbricks#1513) feat: picture selection question (formbricks#1388) feat: formtribe leaderboard update as per today (formbricks#1505) fix: Added if statement for preventing use of reserved word in question ID (formbricks#1435) fix: Disabling Welcome Card leads buggy preview (formbricks#1320) ...
What does this PR do?
Added Picture selection question
Fixes #1256
Type of change
How should this be tested?
Checklist
Required
pnpm buildconsole.logsgit pull origin mainAppreciated