Skip to content

feat: adds hidden field functionality to surveys#1144

Merged
mattinannt merged 13 commits intoformbricks:mainfrom
rtpa25:feat/add-hidden-fields
Oct 15, 2023
Merged

feat: adds hidden field functionality to surveys#1144
mattinannt merged 13 commits intoformbricks:mainfrom
rtpa25:feat/add-hidden-fields

Conversation

@rtpa25
Copy link
Copy Markdown
Contributor

@rtpa25 rtpa25 commented Oct 14, 2023 •
edited
Loading

What does this PR do?

Fixes (#887)

https://www.loom.com/share/5b5ecc20a80241c3aedb1c3f3d8bac69

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Chore (refactoring code, technical debt, workflow improvements)
  • Enhancement (small improvements)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change adds a new database migration
  • This change requires a documentation update

Checklist

Required

  • Read How we Code at Formbricks
  • Self-reviewed my own code
  • Commented on my code in hard-to-understand bits
  • Ran pnpm build
  • Checked for warnings, there are none
  • Removed all console.logs
  • Merged the latest changes from main onto my branch with git pull origin main
  • My changes don't cause any responsiveness issues

Appreciated

  • If a UI change was made: Added a screen recording or screenshots to this PR

@vercel
Copy link
Copy Markdown

vercel bot commented Oct 14, 2023

@rtpa25 is attempting to deploy a commit to the formbricks Team on Vercel.

A member of the Team first needs to authorize it.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Oct 14, 2023 •
edited
Loading

Thank you for following the naming conventions for pull request titles! 🙏

@rtpa25 rtpa25 marked this pull request as draft October 14, 2023 10:17
@jobenjada
Copy link
Copy Markdown
Member

jobenjada commented Oct 14, 2023

Tweaked the UI but struggle to push it:

image image

Also, if someone copies a value incl. a space, it can be submitted:
image

Looking forward to the final PR :)

@rtpa25
Copy link
Copy Markdown
Contributor Author

rtpa25 commented Oct 14, 2023 via email

rtpa25
rtpa25 commented Oct 15, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor Author

@rtpa25 rtpa25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rtpa25 rtpa25 changed the title feat: adds hidden field inside every form and works on basic crud feat: adds hidden field functionality to surveys Oct 15, 2023
@rtpa25 rtpa25 marked this pull request as ready for review October 15, 2023 04:31
@rtpa25
Copy link
Copy Markdown
Contributor Author

rtpa25 commented Oct 15, 2023

@jobenjada @mattinannt awaiting review

@mattinannt
Copy link
Copy Markdown
Member

mattinannt commented Oct 15, 2023

@rtpa25 Thanks a lot for the feature :-) 💪 Looks great!
We now have mix a different terms in Code and UI. Can you please rename the code variables and files that it's named Hidden Field instead of Hidden Question to be consistent?

@rtpa25
Copy link
Copy Markdown
Contributor Author

rtpa25 commented Oct 15, 2023

Done ☑️

@jobenjada jobenjada self-assigned this Oct 15, 2023
@jobenjada jobenjada added hacktoberfest complete these issues to gather points for Hacktoberfest hacktoberfest-accepted formtribe-2023 labels Oct 15, 2023
@mattinannt mattinannt enabled auto-merge October 15, 2023 17:19
@mattinannt mattinannt added this pull request to the merge queue Oct 15, 2023
Merged via the queue into formbricks:main with commit a71ad7c Oct 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mattinannt mattinannt mattinannt approved these changes

Assignees

@jobenjada jobenjada

Labels

hacktoberfest complete these issues to gather points for Hacktoberfest hacktoberfest-accepted ❗️ migrations

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@rtpa25 @jobenjada @mattinannt