feat: Added Dynamic Link Previews#1093
Conversation
|
@anjy7 is attempting to deploy a commit to the formbricks Team on Vercel. A member of the Team first needs to authorize it. |
|
Thank you for following the naming conventions for pull request titles! 🙏 |
|
@anjy7 can you add a screenshot or recording for reference? :) |
Yeah its a work in progress, will add soon. Working on the the image.. |
|
Hey @jobenjada, its ready, please have a look. The brand color and the survey name is dynamic.. |
sure, I'll look into this and get back to you @jobenjada |
|
@anjy7 perfect :) I know it'll be Monday morning, but can you maybe have a look tomorrow? :D Would love to include this in our Week 2 Review which I'll record tomorrow afternoon (would be evening in India) |
|
Hey @jobenjada, trying to debug it at present. And sure I’ll try to do it before evening :) |
|
Hey @jobenjada , I have made the changes, please have a look :) |
apps/web/pages/api/v1/environments/[environmentId]/surveys/[surveyId]/og/index.tsx
Outdated
Show resolved
Hide resolved
mattinannt
left a comment
There was a problem hiding this comment.
@anjy7 thanks a lot for the PR, looks great! From the technical side I would like to see a few more things changed before we merge the changes.
|
Hey @mattinannt, I have made the changes. Also the share button wasn't working on the survey as ig someone had put a check whether the survey is single use or not ( this prevented the share dropdown opening if the survey is not single use ). I have removed it, please check it once :) |
|
@anjy7 thanks a lot for the changes and also fixing the bug on the way :-) 💪 I will merge the PR now :-) |
|
@anjy7 Unfortunately there is still a build error in the PR: Can you please solve this? :-) Then we are ready to merge! :-) |
|
Hey @mattinannt, I’ll look into this in a bit |
|
Hi @mattinannt, I built it locally and all the test cases passed.. |
|
should work now @mattinannt |







What does this PR do?
Adds Dynamic Link Previews
Fixes #1064
Type of change
How should this be tested?
Checklist
Required
pnpm buildconsole.logsgit pull origin mainAppreciated