feat: Add welcome card by KapadiaNaitik · Pull Request #1073 · formbricks/formbricks

KapadiaNaitik · 2023-10-10T11:55:07Z

What does this PR do?

Fixes #1055

Type of change

Bug fix (non-breaking change which fixes an issue)
Chore (refactoring code, technical debt, workflow improvements)
Enhancement (small improvements)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to not work as expected)
This change adds a new database migration
This change requires a documentation update

How should this be tested?

Test A
Test B

Checklist

Required

Will Update During Final Review

Filled out the "How to test" section in this PR
Read How we Code at Formbricks
Self-reviewed my own code
Commented on my code in hard-to-understand bits
Ran pnpm build
Checked for warnings, there are none
Removed all console.logs
Merged the latest changes from main onto my branch with git pull origin main
My changes don't cause any responsiveness issues

Appreciated

If a UI change was made: Added a screen recording or screenshots to this PR
Updated the Formbricks Docs if changes were necessary

vercel · 2023-10-10T11:55:12Z

@KapadiaNaitik is attempting to deploy a commit to the formbricks Team on Vercel.

A member of the Team first needs to authorize it.

github-actions · 2023-10-10T11:55:23Z

Thank you for following the naming conventions for pull request titles! 🙏

…welcome

…into welcome

jobenjada · 2023-10-13T08:28:29Z

Hey @KapadiaNaitik how is it? Is this ready for review as discussed on Discord? :) Would love to release the other upload related issues today which would reuse some of your code, so this should get merged today :pray

jobenjada · 2023-10-13T08:29:04Z

Hey @KapadiaNaitik how is it? Is this ready for review as discussed on Discord? :) Would love to release the other upload related issues today which would reuse some of your code, so this should get merged today :pray

KapadiaNaitik · 2023-10-13T08:35:25Z

Hey, @jobenjada it's done except for the Lucide Icon for enter and I was facing some issues with types/react and Lucide icon. I have already talked to and informed @pandeymangg and he had a look(it was a weird dependency issue afaik). I will follow up once again with him and get this done as soon as possible. Sorry for the delay

pandeymangg

Thanks a lot @KapadiaNaitik for this PR! looks and works great! 🥳
I have left some comments, please go through them. For using the Image component from next/image, you'll need to modify the images.remotePatterns field in the next.config.mjs file under apps/web. Please add the following at the end of that array:

{
  protocol: "http",
  hostname: "localhost",
},
{
  protocol: "https",
  hostname: "app.formbricks.com",
},

...[environmentId]/surveys/[surveyId]/(analysis)/summary/components/shareEmbedTabs/EmailTab.tsx

apps/web/app/(app)/environments/[environmentId]/surveys/[surveyId]/edit/WelcomeQuestionForm.tsx

pandeymangg · 2023-10-14T08:20:43Z

packages/surveys/src/components/WelcomeQuestion.tsx

+  return (
+    <div>
+      {question.companyLogo && (
+        <img


Please use the Image component from next/image here 🙏

next/Image not working for some reason

…welcome

…into welcome

KapadiaNaitik · 2023-10-17T06:35:37Z

@jobenjada I have pushed the required tweaks

pandeymangg · 2023-10-17T08:19:03Z

LGTM! 🥳

…lcome

KapadiaNaitik · 2023-10-17T09:14:01Z

Hey @mattinannt looks like I and you both pushed our commits so welcomeCard got duplicated in clientSettings😅

sentry · 2023-10-17T10:51:12Z

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

‼️ Error: Upload failed with status: 401 uploadFile(chunks/app/(app)/environments/[envir... View Issue
‼️ Error: Upload failed with status: 400 uploadFile(chunks/app/(app)/environments/[envir... View Issue

_{Did you find this useful? React with a 👍 or 👎}

KapadiaNaitik and others added 2 commits October 10, 2023 17:17

Initial Setup For New Welcome Question

3123285

Merge branch 'formbricks:main' into welcome

e6baa8a

github-actions bot added enhancement New feature or request formtribe-2023 hacktoberfest complete these issues to gather points for Hacktoberfest labels Oct 10, 2023

KapadiaNaitik marked this pull request as draft October 10, 2023 11:56

KapadiaNaitik and others added 14 commits October 10, 2023 18:48

Switch Toggle Update, Default false

18a7d58

Merge branch 'formbricks:main' into welcome

ea48780

UI Similarity && Upload Working

4b09550

Drag and Upload

770d3bb

Always First

0479f24

Merge branch 'formbricks:main' into welcome

475ac50

Merge branch 'formbricks:main' into welcome

d412ff8

Merge branch 'main' of https://github.com/formbricks/formbricks into …

5a08bb1

…welcome

Merge branch 'formbricks:main' into welcome

4b5129e

Merge branch 'formbricks:main' into welcome

551327e

Merge branch 'welcome' of https://github.com/KapadiaNaitik/formbricks …

08306fe

…into welcome

Update Imports

602d0f8

Merge branch 'formbricks:main' into welcome

490c871

Lucide Icon-added

a7e38c0

KapadiaNaitik and others added 2 commits October 13, 2023 14:42

Merge branch 'formbricks:main' into welcome

ba3196e

Email Tab and Enter Icon

c4479b6

KapadiaNaitik marked this pull request as ready for review October 13, 2023 09:44

pandeymangg requested changes Oct 14, 2023

View reviewed changes

Merge branch 'main' of https://github.com/formbricks/formbricks into …

a488723

…welcome

jobenjada and others added 3 commits October 16, 2023 23:26

Merge branch 'main' into welcome

5811ea1

Merge branch 'welcome' of https://github.com/KapadiaNaitik/formbricks …

89c9142

…into welcome

Welcome Card Placeholder & toggle

e2cc352

Initial State of LinkSurvey

dac2484

Merge branch 'main' into welcome

fbe0dd9

pandeymangg approved these changes Oct 17, 2023

View reviewed changes

mattinannt enabled auto-merge October 17, 2023 08:25

mattinannt added this pull request to the merge queue Oct 17, 2023

github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 17, 2023

KapadiaNaitik and others added 2 commits October 17, 2023 14:24

fix: clientSettings Welcome Card

ed68349

solve build errors

0c78678

mattinannt changed the title ~~feat: New Question Type Welcome~~ feat: Add welcome card Oct 17, 2023

Merge branch 'main' into welcome

928b28c

mattinannt enabled auto-merge October 17, 2023 08:56

mattinannt disabled auto-merge October 17, 2023 08:59

Merge branch 'welcome' of github.com:KapadiaNaitik/formbricks into we…

4f15dd6

…lcome

mattinannt enabled auto-merge October 17, 2023 08:59

mattinannt added this pull request to the merge queue Oct 17, 2023

github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 17, 2023

mattinannt added 2 commits October 17, 2023 11:21

update client settings

7ba5897

Merge branch 'main' into welcome

c032648

mattinannt enabled auto-merge October 17, 2023 09:21

mattinannt added this pull request to the merge queue Oct 17, 2023

Merged via the queue into formbricks:main with commit 2c1abf8 Oct 17, 2023

KapadiaNaitik deleted the welcome branch October 20, 2023 09:49

Conversation

KapadiaNaitik commented Oct 10, 2023

What does this PR do?

Type of change

How should this be tested?

Checklist

Required

Appreciated

Uh oh!

vercel bot commented Oct 10, 2023

Uh oh!

github-actions bot commented Oct 10, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jobenjada commented Oct 13, 2023

Uh oh!

jobenjada commented Oct 13, 2023

Uh oh!

KapadiaNaitik commented Oct 13, 2023

Uh oh!

pandeymangg left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

pandeymangg Oct 14, 2023

Choose a reason for hiding this comment

Uh oh!

KapadiaNaitik Oct 14, 2023

Choose a reason for hiding this comment

Uh oh!

KapadiaNaitik commented Oct 17, 2023

Uh oh!

pandeymangg commented Oct 17, 2023

Uh oh!

Uh oh!

Uh oh!

KapadiaNaitik commented Oct 17, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

sentry bot commented Oct 17, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Suspect Issues

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

github-actions bot commented Oct 10, 2023 •

edited

Loading

pandeymangg left a comment •

edited

Loading

KapadiaNaitik commented Oct 17, 2023 •

edited

Loading

sentry bot commented Oct 17, 2023 •

edited

Loading