fix(@formatjs/intl-durationformat): declare @formatjs/bigdecimal dependency#6468
Merged
fix(@formatjs/intl-durationformat): declare @formatjs/bigdecimal dependency#6468
Conversation
…ndency The polyfill bundle imports BigDecimal (added in #6466 for sub-second rollup precision), but @formatjs/bigdecimal was only listed in BUILD.bazel — not in package.json. rolldown externalizes it, so consumers hit "Rolldown failed to resolve import @formatjs/bigdecimal" at build time after updating to 0.10.6. Fixes #6467 Co-Authored-By: Claude Opus 4.7 (1M context) <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
@formatjs/bigdecimalto@formatjs/intl-durationformat'sdependencies. The polyfill bundle externalizes it (introduced in fix(@formatjs/intl-durationformat): use BigDecimal for sub-second rollups #6466 for sub-second rollup precision), but it was only declared in BUILD.bazel — not inpackage.json. Consumers updating to 0.10.6 hitRolldown failed to resolve import @formatjs/bigdecimalat build time.Fixes #6467.
Why this slipped past CI
tools/check-package-json.tsexists for exactly this validation, but the Bazel rule that wires it up (package_json_testintools/index.bzl:410-439) is commented out as a TODO. Will follow up with a separate PR to re-enable it across all packages.Test plan
bazel test //packages/intl-durationformat:intl-durationformat_testbazel-bin/packages/intl-durationformat/pkg/package.json—@formatjs/bigdecimalnow appears independencies🤖 Generated with Claude Code