fix(@formatjs/unplugin): strip query/hash in transformInclude#6465
Merged
fix(@formatjs/unplugin): strip query/hash in transformInclude#6465
Conversation
React Router splits routes that export clientLoader/clientAction into virtual chunk modules with IDs like `route.tsx?route-chunk=main`. The plain `\.[jt]sx?$` test rejected those, so defineMessage calls in those chunks never got their id injected during production builds. Strip `?…` and `#…` off the id before the extension check. Fixes #6455 Co-Authored-By: Claude Opus 4.7 (1M context) <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
clientLoader/clientActioninto virtual chunk modules with IDs likeroute.tsx?route-chunk=main. The plain\.[jt]sx?$test intransformIncluderejected those, sodefineMessagecalls in those chunks never got theiridinjected during production builds.?…and#…off the id before the extension check.node_modulescase with a query).Fixes #6455
Test plan
bazel test //packages/unplugin/...— all tests pass, including the new regression case🤖 Generated with Claude Code