fix(formatjs_cli): extract formatMessage from callbacks inside optional chains#6460
Merged
longlho merged 4 commits intoformatjs:mainfrom Apr 28, 2026
Merged
Conversation
Adds the GH formatjs#6459 case to both the CLI conformance suite (Rust + TS) and the ts-transformer extraction assertion so the regression is guarded across all three extractors. Co-Authored-By: Claude Opus 4.7 (1M context) <[email protected]>
Co-Authored-By: Claude Opus 4.7 (1M context) <[email protected]>
longlho
changed the title
2 tasks
Contributor
Author
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #6459.
The Rust CLI's chain-expression visitor walked into call expression arguments, but skipped the callee. As a result,
formatMessagecalls inside callbacks passed to optional-chain methods (e.g.getUsers()?.map(() => intl.formatMessage(...))) were never extracted.Changes
CallExpressionchain element so nestedformatMessagecalls inside callback bodies are extracted.StaticMemberExpressionarm —walk_chain_expressioncovers it via the default case.packages/ts-transformer/tests/fixtures/optionalChaining.tsx.crates/formatjs_cli/src/extractor.rs.packages/ts-transformer/tests/index.test.ts.22_callback_in_optional_chain.txtso both Rust and TS extractors are guarded.Test plan
bazel test //crates/formatjs_cli:formatjs_cli_testbazel test //packages/ts-transformer:ts-transformer_testbazel test //packages/cli/integration-tests:conformance_test