Skip to content

Commit 104cbb1

Browse files
longlhoclaude
andauthored
fix(@formatjs/intl-durationformat): declare @formatjs/bigdecimal dependency (#6468)
## Summary - Add `@formatjs/bigdecimal` to `@formatjs/intl-durationformat`'s `dependencies`. The polyfill bundle externalizes it (introduced in #6466 for sub-second rollup precision), but it was only declared in BUILD.bazel — not in `package.json`. Consumers updating to 0.10.6 hit `Rolldown failed to resolve import @formatjs/bigdecimal` at build time. Fixes #6467. ## Why this slipped past CI `tools/check-package-json.ts` exists for exactly this validation, but the Bazel rule that wires it up (`package_json_test` in `tools/index.bzl:410-439`) is commented out as a TODO. Will follow up with a separate PR to re-enable it across all packages. ## Test plan - [x] `bazel test //packages/intl-durationformat:intl-durationformat_test` - [x] Inspected `bazel-bin/packages/intl-durationformat/pkg/package.json` — `@formatjs/bigdecimal` now appears in `dependencies` 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-authored-by: Claude Opus 4.7 (1M context) <[email protected]>
1 parent 19952b1 commit 104cbb1

2 files changed

Lines changed: 4 additions & 0 deletions

File tree

packages/intl-durationformat/package.json

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,7 @@
1313
"./should-polyfill.js": "./should-polyfill.js"
1414
},
1515
"dependencies": {
16+
"@formatjs/bigdecimal": "workspace:*",
1617
"@formatjs/intl-localematcher": "workspace:*"
1718
},
1819
"bugs": "https://github.com/formatjs/formatjs/issues",

pnpm-lock.yaml

Lines changed: 3 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)