Skip to content

Conversation

@paradoxmr24
Copy link

Removed the deprecated code and updated it.

@RobinTail
Copy link

util.isArray is deprecated since Node v4.0.0
https://nodejs.org/api/util.html#utilisarrayobject

@niftylettuce , please review

RobinTail added a commit to RobinTail/express-zod-api that referenced this pull request Mar 24, 2024
Needed for #1617 
Related to form-data/form-data#558

Using the native Node 18+ FormData (using it in tests).
It turned out that in version 18.0.0 (only), `FormData::set` and
`::append()` do not take the MIME type of the `Blob` into account, and
it's an empty string, which always lead to `application/octet-stream`
instead of actual MIME type.

`Blob::type` is readonly via getter-only approach, so there is no way to
hack it.
So I disabled the MIME type check for Node 18.0.0 test.
@ljharb
Copy link
Member

ljharb commented Sep 20, 2024

Duplicate of #564.

@ljharb ljharb closed this Sep 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants