#47 return request from .submit()#48
Merged
alexindigo merged 2 commits intoform-data:masterfrom Aug 22, 2013
Merged
Conversation
Contributor
|
LGTM - 💖 @visionmedia - what do you think? |
|
yup LGTM! |
Member
Author
|
Ok, I'll update readme and merge it. |
Member
Author
|
Haha, I was going thru the docs to find where to put new info and bumped into this one: var request = http.request({
method: 'post',
host: 'example.org',
path: '/upload',
headers: form.getHeaders()
});
form.pipe(request);Looks like it was there all the time. :) Do you still want the change? |
|
still handy to ignore the rest of that stuff, especially since you can't pass a url string to http.request due to headers and other stuff being required on the same object |
alexindigo
added a commit
that referenced
this pull request
Aug 22, 2013
#47 return request from .submit()
Member
Author
|
@visionmedia It's on npm – |
|
@alexindigo thanks man |
Contributor
|
@alexindigo 💖 thx! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.