Skip to content

#47 return request from .submit()#48

Merged
alexindigo merged 2 commits intoform-data:masterfrom
alexindigo:master
Aug 22, 2013
Merged

#47 return request from .submit()#48
alexindigo merged 2 commits intoform-data:masterfrom
alexindigo:master

Conversation

@alexindigo
Copy link
Copy Markdown
Member

No description provided.

@felixge
Copy link
Copy Markdown
Contributor

felixge commented Aug 21, 2013

LGTM - 💖 @visionmedia - what do you think?

@tj
Copy link
Copy Markdown

tj commented Aug 21, 2013

yup LGTM!

@alexindigo
Copy link
Copy Markdown
Member Author

Ok, I'll update readme and merge it.

@alexindigo
Copy link
Copy Markdown
Member Author

Haha, I was going thru the docs to find where to put new info and bumped into this one:

var request = http.request({
  method: 'post',
  host: 'example.org',
  path: '/upload',
  headers: form.getHeaders()
});

form.pipe(request);

Looks like it was there all the time. :)

Do you still want the change?

@tj
Copy link
Copy Markdown

tj commented Aug 21, 2013

still handy to ignore the rest of that stuff, especially since you can't pass a url string to http.request due to headers and other stuff being required on the same object

alexindigo added a commit that referenced this pull request Aug 22, 2013
#47 return request from .submit()
@alexindigo alexindigo merged commit ab18129 into form-data:master Aug 22, 2013
@alexindigo
Copy link
Copy Markdown
Member Author

@visionmedia It's on npm – 0.1.1.

@tj
Copy link
Copy Markdown

tj commented Aug 22, 2013

@alexindigo thanks man

@felixge
Copy link
Copy Markdown
Contributor

felixge commented Aug 22, 2013

@alexindigo 💖 thx!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants