Consuming the request data so the connection closes properly in form-data.submit.#45
Consuming the request data so the connection closes properly in form-data.submit.#45D1plo1d wants to merge 3 commits intoform-data:masterfrom
Conversation
|
It will be very nice to see the tests. Thank you. |
|
Tested. If you cherry pick that test ( I'm not sure whether this or adding |
|
Thanx for the test. |
|
I'm running v0.10.15. I haven't tested it against any other node versions. |
|
I see. I'll play with it. |
|
So if I run your test within original codebase, it doesn't fail for any version ( This fix, would trigger all the requests into "old mode", which might be not desirable default behavior in As for documentation it was discussed in lengths and described here: http://nodejs.org/api/stream.html#stream_compatibility_with_older_node_versions But you're right, we need to make it more obvious. Thanx a lot. |
#45 Added tests for multi-submit. Updated readme.
This patch fixes the problem where form-data could only submit up to 5 posts to a particular server before it would stall out indefinitely (on the 6th post).
See http://stackoverflow.com/a/16967747/386193