-
Notifications
You must be signed in to change notification settings - Fork 380
form-data: Replaced PhantomJS Dependency #442
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: sakshi87 <[email protected]>
|
LGTM. But removing support for Node 4 should be a breaking change. |
|
Does |
|
@mapleeit As you can check, the Travis-ci builds the package is working fine on NodeJS v6 as well with the puppeteer. I will be happy to update the PR though if you want these two changes separated, Please consider merging this PR. |
|
I mean can the code still runs on Node4 after changing? If it's not, then it is a breaking change. We should be carefully of that. |
|
No, it doesn't work after change on Node v4, I agree this is a breaking change but the older node version is not supported by the puppeteer. The puppeteer atleast requires node v6, that's why it is giving issue on node v4. Please suggest what needs to be done to get this PR merged. |
|
@alexindigo Please take a look when you have time. I'm not sure about how to handle this. |
|
Sounds good to me. In addition, we should also update |
Phantomjs is an unmaintained project, replaced the phantomjs dependency with the puppeteer.
Updated the travis.yml to remove the nodejs version 4 as mentioned in #398.