Skip to content

Fix error in callback signatures#435

Merged
mapleeit merged 2 commits intoform-data:masterfrom
LinusU:patch-1
Aug 27, 2019
Merged

Fix error in callback signatures#435
mapleeit merged 2 commits intoform-data:masterfrom
LinusU:patch-1

Conversation

@LinusU
Copy link
Copy Markdown
Contributor

@LinusU LinusU commented Aug 2, 2019

The functions actually give null as the error parameter, and not undefined.

Without this, util.promisify can't be typed correctly on these functions as it expects the callback to receive Error | null.

@LinusU
Fix error in callback signatures
09fcc98 
The functions actually give `null` as the error parameter, and not `undefined`.

Without this, `util.promisify` can't be typed correctly on these functions as it expects the callback to receive `Error | null`.
@coveralls
Copy link
Copy Markdown

coveralls commented Aug 2, 2019 •
edited
Loading

Coverage Status

Coverage remained the same at 98.122% when pulling a6bc2d4 on LinusU:patch-1 into 905f173 on form-data:master.

@mapleeit
Copy link
Copy Markdown
Collaborator

mapleeit commented Aug 3, 2019

/rebuild

@mapleeit
Copy link
Copy Markdown
Collaborator

mapleeit commented Aug 3, 2019

LGTM

@LinusU
Copy link
Copy Markdown
Contributor Author

LinusU commented Aug 3, 2019

The build is failing on Windows w/ Node 4:

$ nvs add 4
Downloading bootstrap node from https://nodejs.org/dist/v10.12.0/node-v10.12.0-win-x64.7z
Failed to download node binary.
The command "nvs add 4" failed and exited with 1 during .

@LinusU LinusU mentioned this pull request Aug 3, 2019
Closed
4 tasks
@LinusU
Copy link
Copy Markdown
Contributor Author

LinusU commented Aug 13, 2019

ping @mapleeit, could you restart the build for windows/node4?

@mapleeit
Copy link
Copy Markdown
Collaborator

mapleeit commented Aug 14, 2019

ping @mapleeit, could you restart the build for windows/node4?

done.

@LinusU
Copy link
Copy Markdown
Contributor Author

LinusU commented Aug 14, 2019

Ugh, we're blocked on isaacs/rimraf#195 😅

@LinusU LinusU mentioned this pull request Aug 14, 2019
Closed
@mapleeit
Copy link
Copy Markdown
Collaborator

mapleeit commented Aug 14, 2019 •
edited
Loading

I'm afraid so. Can ping me again when it's ready. 😄

@LinusU
Copy link
Copy Markdown
Contributor Author

LinusU commented Aug 14, 2019

@mapleeit should be good to go now, mind restarting the build again?

@mapleeit
Copy link
Copy Markdown
Collaborator

mapleeit commented Aug 15, 2019

Done, waiting for the result. : )

@mapleeit
Copy link
Copy Markdown
Collaborator

mapleeit commented Aug 15, 2019 •
edited
Loading

@LinusU still failed, should we update the version of rimraf in package.json?

@LinusU
Copy link
Copy Markdown
Contributor Author

LinusU commented Aug 15, 2019

Did it 👌

@mapleeit mapleeit requested a review from alexindigo August 15, 2019 09:16
@mapleeit
Copy link
Copy Markdown
Collaborator

mapleeit commented Aug 15, 2019

LGTM.

@alexindigo Please take a look if you have time. : )

@mapleeit
Copy link
Copy Markdown
Collaborator

mapleeit commented Aug 20, 2019

ping @alexindigo

@alexindigo
Copy link
Copy Markdown
Member

alexindigo commented Aug 26, 2019

@mapleeit Looks good to me, unless it’s a trick question. :)
Do you want me to merge or you’re ok pushing the button yourself?
Thanks.

@mapleeit mapleeit merged commit e8827ff into form-data:master Aug 27, 2019
@mapleeit
Copy link
Copy Markdown
Collaborator

mapleeit commented Aug 27, 2019

Both is ok to me, haha.
I merged this. Thanks! @LinusU

@LinusU LinusU deleted the patch-1 branch August 27, 2019 16:04
@LinusU
Copy link
Copy Markdown
Contributor Author

LinusU commented Aug 27, 2019 •
edited
Loading

Would be great if we could get a release cut with this so that we can move forward with sindresorhus/got#849 ☺️

@mapleeit
Copy link
Copy Markdown
Collaborator

mapleeit commented Aug 28, 2019

We need to ping @alexindigo again 😄

@alexindigo
Copy link
Copy Markdown
Member

alexindigo commented Aug 29, 2019

@LinusU @mapleeit Published 2.5.1. Thanks a lot.

@LinusU
Copy link
Copy Markdown
Contributor Author

LinusU commented Aug 29, 2019

Thanks 👏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alexindigo alexindigo alexindigo approved these changes

+1 more reviewer

@sindresorhus sindresorhus sindresorhus approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@LinusU @coveralls @mapleeit @alexindigo @sindresorhus