0.1.0 - Added error handling. Streamlined edge cases behavior.#43
Merged
alexindigo merged 5 commits intoform-data:0.1.0from Jul 8, 2013
Merged
0.1.0 - Added error handling. Streamlined edge cases behavior.#43alexindigo merged 5 commits intoform-data:0.1.0from
alexindigo merged 5 commits intoform-data:0.1.0from
Conversation
form-data#38 Added check for array data type. form-data#40 Added check for attached streams in getLengthSync. - Emits error in both cases.
Contributor
There was a problem hiding this comment.
style: brace should be on same line
Contributor
|
Patch LGTM! |
Contributor
|
💖 |
alexindigo
added a commit
that referenced
this pull request
Jul 8, 2013
0.1.0 - Added error handling. Streamlined edge cases behavior.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@felixge There were few problems similar to #38 and #40,
so I added error handling and made it a little bit more verbose.
Changes are mostly backwards compatible for real life use cases,
but it breaks on small number edge cases, like if you call getLengthSync with attached stream(s),
before if would return wrong data and now it would emit error.
So I bumped the minor version.
Please review if you ok with the direction it's going.
Thank you.