Coverage remained the same at 98.122% when pulling a3c0142 on feat/add-typings into 87751e0 on master.

Let's get other chance to review ;)

Let's get other chance to review ;)

Sure, my bad.

Hi, @tabeth , do you have time to take a look at this. I'm not sure that is this @types/node dep necessary.

Thanks a lot, your help really appreciated. 🙏

@alexindigo @mapleeit

If we're going to maintain types outside of DefinitelyTyped, then yes, we do have to include @types/node as a dependency. Though personally I think it makes more sense to just open a pull request in DefinitelyTyped than in this repository. If we are going to continue in this way, we should to submit a PR to remove the types from DefinitelyTyped to avoid confusion.

To be honest, I'm a little confused about where is the best place to put typings files.

DefinitelyTyped is one option. But I think it may be not the best option for the convenience of usage and maintaining? (I already made a PR to DefinitelyTyped 5 days ago, still no response) And people must install @types/form-data.

I saw axios put typing file in their own repo. So I think it is an option?

I'll make a PR to remove the types from DefinitelyTyped if we decide to store it at here. I could also revert this commit if we decide to not, considering we still not have a new npm version.

@mapleeit @tabeth I don't any types in prod dependencies in axios:
https://github.com/axios/axios/blob/master/package.json#L75-L78

@alexindigo Yes, because the typing file of axios is quite simple. It doesn't use stream and http definition within NodeJS.

https://github.com/form-data/form-data/blob/master/index.d.ts#L6

This is what they have in DefinitelyTyped:

And this is next.js server, that uses TS and relying on node modules, like http:
https://github.com/zeit/next.js/tree/canary/packages/next-server
– No prod types dependencies.

Also I'm seeing @types/node as devDep in Electron:
https://github.com/electron/electron/blob/master/package.json#L15

Let's try to put it into devDep and see how it works.

@alexindigo @mapleeit

Yeah, it would be better to put them in devDependencies. The types don't compile to usable code anyway, so it wouldn't actually amount to much to make them a regular dependency.

Agreed with devDependencies.

@tabeth @alexindigo I made a PR to move @types/node, please take a look when you have time : )

Then we may can release a version and I remove the @types/form-data from DefinitelyTyped.