enhance the method of path.basename#421
Conversation
value.client._httpMessage.path maybe return undefined, and cause error: `TypeError [ERR_INVALID_ARG_TYPE]: The "path" argument must be of type string. Received type undefined`。 Add `|| ''` to enhance quality。
|
LGTM Maybe we should merge this. : ) @alexindigo |
|
Thank you @mapleeit, I added you as collaborator, please merge when you're ready. |
|
Ok, thanks for the trust. I saw CI rerun several times, but failed in different environment. A little weird. |
|
Yeah windows builds very unstable 🤦♂ |
🤭It really sucks. Is there any alternatives for windows building? |
|
@mapleeit @alexindigo Yes Travis. |
|
@codenirvana Thanks for the information! Could we use Travis for windows building instead? Considering the unstable cases now. @alexindigo |
|
@MapleIT I wasn’t aware Travis has windows support. Do you have link to the docs by any chance? Thank you. |
|
Oh, I see it :) Yes, let’s try that thing. :) |
4 participants
value.client._httpMessage.path maybe return undefined, and cause error:
TypeError [ERR_INVALID_ARG_TYPE]: The "path" argument must be of type string. Received type undefined。Add
|| ''to enhance quality。