Removes the 2mb maxDataSize limitation#368
Conversation
| this._valuesToMeasure = []; | ||
|
|
||
| CombinedStream.call(this); | ||
| Object.assign(this, CombinedStream.create(options)); |
There was a problem hiding this comment.
As I can see Object.assign is failing builds do you want me to use util._extend, or write a util function to do it?
There was a problem hiding this comment.
You can just copy same loop from https://github.com/felixge/node-combined-stream/blob/master/lib/combined_stream.js#L22-L25
Also, I'd keep using CombinedStream.call(this); and would add that options loop after that.
There was a problem hiding this comment.
Sure, makes sense. Done
|
Cool. Thanks a lot. Do you mind to throw in extra test for the use case we've covered here – to make coveralls happy? :) Thank you. |
|
Added tests, please have a look. |
|
Perfect, thanks. Will publish updated version later today. |
|
That would be great. Thanks a lot for the support :) |
|
Published as |
3 participants
No description provided.