Boilerplate code rediction#265
Merged
alexindigo merged 2 commits intoform-data:masterfrom Oct 2, 2016
trierra:code-duplicates-fix
Merged
Boilerplate code rediction#265alexindigo merged 2 commits intoform-data:masterfrom trierra:code-duplicates-fix
alexindigo merged 2 commits intoform-data:masterfrom
trierra:code-duplicates-fix
Conversation
alexindigo
requested changes
Sep 30, 2016
Member
alexindigo
left a comment
alexindigo
left a comment
There was a problem hiding this comment.
Hey,
Thanksalot (some kind of knight) for the PR, looks awesome!
There are couple things that could use some improvement, but other than that. 👍 💯
Thank you.
|
|
||
| form.parse(req); | ||
|
|
||
| var fieldsPassed = Object.keys(FIELDS).length; |
Member
There was a problem hiding this comment.
Do you mind to put it to the top of the function?
To keep it with the spirit of hoisting. :)
And actually it would be good at the top of the common.createServer,
so it won't be redefined on each request, in case we'd get multi-request tests.
| // prepare form-receiving http server | ||
| server = http.createServer(function(req, res) { | ||
| var incomingForm = new IncomingForm({uploadDir: common.dir.tmp}); | ||
|
|
Member
There was a problem hiding this comment.
And this one, we need new instance on each request, so it could go into http.createServer of common.js.
| // finish it | ||
| common.actions.formOnEnd(res); | ||
| }); | ||
| server = common.createServer(incomingForm, FIELDS, function(fields){ |
Member
There was a problem hiding this comment.
And with that, you probably can rename common.createServer to common.testFields.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Boilerplate code reduced
