Allow paths as filenames in multipart/form-data requests#181
Closed
mneil wants to merge 14 commits intoform-data:masterfrom
Closed
Allow paths as filenames in multipart/form-data requests#181mneil wants to merge 14 commits intoform-data:masterfrom
mneil wants to merge 14 commits intoform-data:masterfrom
Conversation
|
|
Author
|
I should have left this well enough alone. I squashed my commits down but ended up rewriting some of your history where I didn't mean to. I can close this and open another with the correct commit if you'd like. Let me know your preference for PRs |
Collaborator
|
Closing because this PR as the feature has been implemented in #355 which shipped as |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was trying to use this in conjunction with loopback container service which accepts a path as a filename when connecting to S3.
Long story short, the plugin coerces the filename to the files basename — so I can't send a file path as the name like /path/to/file.png.
I tried reading through as much of https://www.ietf.org/rfc/rfc2388.txt https://tools.ietf.org/html/rfc2184 as I could and as far as I can tell the only requirements for the filename are that it is US-ASCII. I like how easy your plugin makes it to send file data as multipart/form-data but I would argue it's the application developers job to determine the logic behind properties such as the filename.
I'd hate to break this for others so maybe adding an option to use basename for now would be good?