Avoid undefined variable reference in older browsers#176
Merged
alexindigo merged 1 commit intoform-data:masterfrom Mar 10, 2016
Merged
Avoid undefined variable reference in older browsers#176alexindigo merged 1 commit intoform-data:masterfrom
alexindigo merged 1 commit intoform-data:masterfrom
Conversation
|
|
Member
|
I can see both sides. So it's up to @DylanPiercey |
Member
|
@alexindigo I think this is a good idea. Still allows for polyfills/fallbacks. I won't be able to merge and release this until tomorrow if not (which is fine for me). |
Member
|
@DylanPiercey I'll take care of the process, just wanted to make sure you didn't have anything else in mind when implementing it. Thanks. |
alexindigo
added a commit
that referenced
this pull request
Mar 10, 2016
Avoid undefined variable reference in older browsers
Member
|
I need to bump up few dependencies and I'll release new version to npm. ETA: this weekend. |
Member
|
Awesome, great work @alexindigo and thanks @pornel for the PR. |
Member
|
Published |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If this code is run in a browser that doesn't have a native
FormDataobject, it'll fail with "FormData is not defined" error.I think it'd be better to return
undefinedin this case, so that the user of this module can handle it gracefully later.