add \r\n to _lastBoundary()#109
Closed
tylergoodman wants to merge 1 commit intoform-data:masterfrom
tylergoodman:master
Closed
add \r\n to _lastBoundary()#109tylergoodman wants to merge 1 commit intoform-data:masterfrom tylergoodman:master
tylergoodman wants to merge 1 commit intoform-data:masterfrom
tylergoodman:master
Conversation
Member
|
Thank you for the interest. Can you elaborate on what kind of clients interact with Form-Data? PS. Tests are failing. |
Author
|
By "client", I mean a recipient of a form-data request. While working on a project I ran into a server that wouldn't accept a request that didn't end in a CRLF. This problem was probably an isolated incident but since I saw that both Chrome and Firefox end their multipart/form-data requests with a CRLF, I figured I would open this PR. Regarding the tests, I'm not sure why they're failing. I tried running them on felixge/node-form-data's master branch and get the same failure. Maybe it's not me? |
alexindigo
pushed a commit
to alexindigo/form-data
that referenced
this pull request
Jun 13, 2015
alexindigo
added a commit
that referenced
this pull request
Jul 22, 2015
#109 Append proper line break
Member
|
Fixed in #123. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some clients seem to be strict about this for some requests.