Merge pull request #446 from Ovyerus/fix-constructor-type

mapleeit · web-flow · commit cd27e9a32466 · 2019-10-29T14:33:47.000+08:00
Fix constructor options in Typescript definitions
diff --git a/index.d.ts b/index.d.ts
@@ -9,7 +9,17 @@ import * as http from 'http';
 
 export = FormData;
 
-interface Options {
+// Extracted because @types/node doesn't export interfaces.
+interface ReadableOptions {
+  highWaterMark?: number;
+  encoding?: string;
+  objectMode?: boolean;
+  read?(this: stream.Readable, size: number): void;
+  destroy?(this: stream.Readable, error: Error | null, callback: (error: Error | null) => void): void;
+  autoDestroy?: boolean;
+}
+
+interface Options extends ReadableOptions {
   writable?: boolean;
   readable?: boolean;
   dataSize?: number;
diff --git a/lib/form_data.js b/lib/form_data.js
@@ -25,7 +25,7 @@ util.inherits(FormData, CombinedStream);
  */
 function FormData(options) {
   if (!(this instanceof FormData)) {
-    return new FormData();
+    return new FormData(options);
   }
 
   this._overheadLength = 0;

Original file line number	Diff line number	Diff line change
`@@ -25,7 +25,7 @@ util.inherits(FormData, CombinedStream);`
`25`	`25`	`*/`
`26`	`26`	`function FormData(options) {`
`27`	`27`	`if (!(this instanceof FormData)) {`
`28`		`- return new FormData();`
	`28`	`+ return new FormData(options);`
`29`	`29`	`}`
`30`	`30`
`31`	`31`	`this._overheadLength = 0;`