Added check for self and window objects + tests

alexindigo · alexindigo · commit c99e4ec32cd1 · 2016-11-07T13:57:24.000-08:00
diff --git a/.istanbul.yml b/.istanbul.yml
@@ -4,7 +4,6 @@ instrumentation:
     extensions:
         - .js
     default-excludes: true
-    excludes: ['lib/browser.js']
 reporting:
     print: summary
     reports:
diff --git a/.travis.yml b/.travis.yml
@@ -20,7 +20,7 @@ script:
   - node --version
   - npm --version
   - npm run ci-lint
-  - npm run test
+  - npm run ci-test
   - npm run check
 
 after_success:
diff --git a/lib/browser.js b/lib/browser.js
@@ -1,2 +1,2 @@
 /* eslint-env browser */
-module.exports = self.FormData;
+module.exports = typeof self == 'object' ? self.FormData : window.FormData;
diff --git a/package.json b/package.json
@@ -14,9 +14,12 @@
     "test": "istanbul cover test/run.js",
     "posttest": "istanbul report lcov text",
     "lint": "eslint lib/*.js test/*.js test/integration/*.js",
-    "ci-lint": "is-node-modern && npm run lint || is-node-not-modern",
+    "report": "istanbul report lcov text",
+    "ci-lint": "is-node-modern 6 && npm run lint || is-node-not-modern 6",
+    "ci-test": "npm run test && npm run browser && npm run report",
     "predebug": "rimraf coverage test/tmp",
     "debug": "verbose=1 ./test/run.js",
+    "browser": "browserify -t browserify-istanbul test/run-browser.js | obake --coverage",
     "check": "istanbul check-coverage coverage/coverage*.json",
     "files": "pkgfiles --sort=name",
     "get-version": "node -e \"console.log(require('./package.json').version)\"",
@@ -27,7 +30,7 @@
   },
   "pre-commit": [
     "lint",
-    "test",
+    "ci-test",
     "check"
   ],
   "engines": {
@@ -39,19 +42,24 @@
     "mime-types": "^2.1.12"
   },
   "devDependencies": {
+    "browserify": "^13.1.1",
+    "browserify-istanbul": "^2.0.0",
     "coveralls": "^2.11.14",
     "cross-spawn": "^4.0.2",
-    "eslint": "^3.7.1",
+    "eslint": "^3.9.1",
     "fake": "^0.2.2",
     "far": "^0.0.7",
     "formidable": "^1.0.17",
     "in-publish": "^2.0.0",
     "is-node-modern": "^1.0.0",
     "istanbul": "^0.4.5",
+    "obake": "^0.1.2",
+    "phantomjs-prebuilt": "^2.1.13",
     "pkgfiles": "^2.3.0",
     "pre-commit": "^1.1.3",
-    "request": "^2.75.0",
-    "rimraf": "^2.5.4"
+    "request": "2.76.0",
+    "rimraf": "^2.5.4",
+    "tape": "^4.6.2"
   },
   "license": "MIT"
 }
diff --git a/test/run-browser.js b/test/run-browser.js
@@ -0,0 +1,11 @@
+var test = require('tape');
+var FormData = require('../lib/browser.js');
+var form = new FormData();
+
+test('being nice to browser-like environments', function(t)
+{
+  t.plan(3);
+  t.notEqual(typeof FormData, 'undefined', 'FormData should be defined');
+  t.equal(typeof form, 'object', 'FormData instance should be object');
+  t.equal(typeof form.append, 'function', 'FormData instance should have `append` method');
+});

Original file line number	Diff line number	Diff line change
`@@ -1,2 +1,2 @@`
`1`	`1`	`/* eslint-env browser */`
`2`		`-module.exports = self.FormData;`
	`2`	`+module.exports = typeof self == 'object' ? self.FormData : window.FormData;`