Implemented a simplistic submit() function

felixge · felixge · commit 41e9cc124124 · 2011-05-28T21:31:12.000+02:00
Still considering to drop this feature if it becomes too much of
a hastle.
diff --git a/lib/form_data.js b/lib/form_data.js
@@ -1,6 +1,8 @@
 var CombinedStream = require('combined-stream');
 var util = require('util');
 var path = require('path');
+var http = require('http');
+var parseUrl = require('url').parse;
 var fs = require('fs');
 var mime = require('mime');
 var async = require('async');
@@ -148,3 +150,24 @@ FormData.prototype.getLength = function(cb) {
     cb(null, knownLength);
   });
 };
+
+FormData.prototype.submit = function(url, cb) {
+  this.getLength(function(err, length) {
+    var parsedUrl = parseUrl(url);
+
+    var request = http.request({
+      method: 'post',
+      port: parsedUrl.port || 80,
+      path: parsedUrl.pathname,
+      headers: this.getHeaders({'Content-Length': length}),
+    });
+
+    this.pipe(request);
+    if (cb) {
+      request.on('error', cb);
+      request.on('response', cb.bind(this, null));
+    }
+
+    return request;
+  }.bind(this));
+};
diff --git a/test/integration/test-pipe.js b/test/integration/test-pipe.js
@@ -41,8 +41,6 @@ server.listen(common.port, function() {
     form.append(field.name, field.value);
   });
 
-  var http = require('http');
-
   var request = http.request({
     method: 'post',
     port: common.port,
diff --git a/test/integration/test-submit.js b/test/integration/test-submit.js
@@ -0,0 +1,56 @@
+var common = require('../common');
+var assert = common.assert;
+var http = require('http');
+var path = require('path');
+var mime = require('mime');
+var fs = require('fs');
+var FormData = require(common.dir.lib + '/form_data');
+var IncomingForm = require('formidable').IncomingForm;
+
+var FIELDS = [
+  {name: 'my_field', value: 'my_value'},
+  {name: 'my_buffer', value: new Buffer([1, 2, 3])},
+  {name: 'my_file', value: fs.createReadStream(common.dir.fixture + '/unicycle.jpg')},
+];
+
+var server = http.createServer(function(req, res) {
+  var form = new IncomingForm();
+  form.uploadDir = common.dir.tmp;
+  form.parse(req);
+  form
+    .on('field', function(name, value) {
+      var field = FIELDS.shift();
+      assert.strictEqual(name, field.name);
+      assert.strictEqual(value, field.value+'');
+    })
+    .on('file', function(name, file) {
+      var field = FIELDS.shift();
+      assert.strictEqual(name, field.name);
+      assert.strictEqual(file.name, path.basename(field.value.path));
+      assert.strictEqual(file.type, mime.lookup(file.name));
+    })
+    .on('end', function() {
+      res.writeHead(200);
+      res.end('done');
+    });
+});
+
+server.listen(common.port, function() {
+  var form = new FormData();
+  FIELDS.forEach(function(field) {
+    form.append(field.name, field.value);
+  });
+
+  form.submit('http://localhost:' + common.port + '/', function(err, res) {
+    if (err) {
+      throw err;
+    }
+
+    assert.strictEqual(res.statusCode, 200);
+    server.close();
+  });
+});
+
+process.on('exit', function() {
+  assert.strictEqual(FIELDS.length, 0);
+});
