Update metadataDeploy.php for php8 support#871
Merged
jonnyhork merged 1 commit intoforceworkbench:mainfrom Mar 30, 2026
Merged
Conversation
Contributor
Author
|
here's the commit that caused the issue: |
Contributor
Author
|
error in question: |
Collaborator
|
@qzak Thanks for addressing this for us! |
jonnyhork
approved these changes
Mar 30, 2026
Collaborator
|
This PR has been deployed to production |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
with the PHP8 upgrade, array_key_exists is limited to arrays only, while $deployOptions is an object. This PR should fix the issue.