Repository navigation
[glyf] Round component offsets when calculating bounds - #4374
Merged
behdad merged 1 commit intoNov 1, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #3795.
Instancing can leave fractional XY component offsets in memory.
GlyphComponent.compile()rounds those offsets when encoding them, butgetCoordinates(round=otRound)used the fractional offsets when calculating bounds. A saved nested composite could therefore contain bounds for a different outline than the one it encodes.Apply the requested rounding function to XY offsets before their transforms. The default
noRoundpath is unchanged. Intermediate transformed coordinates are not additionally rounded. The method documents the rounding behavior.The regressions cover positive/negative offsets and half ties, default/scaled/unscaled offset conventions, direct and nested components, and unchanged unrounded coordinates. The instancer test creates a nested component in an existing variable-font fixture, generates full and partial instances, saves and reloads them, and checks the stored bounds against arithmetic on the decoded points and offsets.
Validation from the repository root on Linux with Python 3.12:
python -m tox -e py,lint,package_readme: passed on the production and test changes; pytest reported 7216 passed, 15 skipped, 2 xfailed, 31 warnings in 81.66s (0:01:21). Black, mypy and wheel/readme validation passed.python -m tox -e package_readmepassed again.The original reporter's font is unavailable, so this addresses the reproduced fractional-offset case without claiming to resolve every cause of the linked report. Other Python versions, Windows/macOS and Cython builds were not run locally.