Repository navigation
[feaLib] raise FeatureLibError for a STAT axis location with no or to… - #4268
Merged
anthrotype merged 1 commit intoOct 9, 2026
Merged
Conversation
…o many values A location takes 1, 2 or 3 values (Axis Value formats 1, 3 and 2). With 0 or 4+ the parser accepted it, the builder skipped the record, and the build then failed in otlLib with a bare KeyError: 'name'.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A STAT
locationtakes 1, 2 or 3 values (Axis Value formats 1, 3 and 2). With 4 values, as inor with none (
location wght;), the parser accepted it,Builder.buildSTATskipped the record because no format matched, and the build then failed inotlLib.builder._buildAxisRecordswith a bareKeyError: 'name'and no line number.parse_STAT_locationnow raises a FeatureLibError at the location: "Expected 1, 2 or 3 values for axis wght, but 4 were found." Added two parser tests next totest_stat_axis_value_format2_bad_range.