Repository navigation
[feaLib] raise FeatureLibError for a UnicodeRange bit outside 0-127 - #4266
Merged
anthrotype merged 1 commit intoOct 9, 2026
Merged
Conversation
table OS/2 { UnicodeRange 200; } was accepted by the parser and then failed
when building, with a bare ValueError from setUnicodeRanges and no line
number.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
table OS/2 { UnicodeRange 0 200; } OS/2;was accepted by the parser and then failed when building, with a bareValueError: expected 0 <= int <= 127, found: 200fromsetUnicodeRangesand no line number.The parser now checks each UnicodeRange bit and raises a FeatureLibError with the location, like other invalid values in a feature file. Added a parser test.