Skip to content

Conversation

@icco
Copy link
Member

@icco icco commented Dec 30, 2013

This should fix #2525.

@icco
Copy link
Member Author

icco commented Dec 30, 2013

The code I tested this with: https://gist.github.com/icco/8178811

It should be noted there is no api AFAICT to verify that the servers were actually scrubbed.

@coveralls
Copy link

Coverage Status

Coverage decreased (-9.23%) when pulling cb95e27 on icco:do_spunge into 732db3e on fog:master.

@icco
Copy link
Member Author

icco commented Dec 30, 2013

Failures are unrelated. Attempting a small patch.

@coveralls
Copy link

Coverage Status

Coverage remained the same when pulling 84a5921 on icco:do_spunge into 732db3e on fog:master.

@icco
Copy link
Member Author

icco commented Dec 30, 2013

Errors are because of #2524, other than that, this is good to go.

@geemus
Copy link
Member

geemus commented Dec 30, 2013

@icco - thanks for tackling this. I'll try to take a look at #2524 soon.

geemus added a commit that referenced this pull request Dec 30, 2013
[digitalocean|compute] Set scrub data to true for all server destroy requests
@geemus geemus merged commit bb17891 into fog:master Dec 30, 2013
@icco icco deleted the do_spunge branch December 30, 2013 21:27
@icco
Copy link
Member Author

icco commented Dec 30, 2013

My pleasure, weirded me out to see a link to a fog issue on the top of hn :p

@geemus
Copy link
Member

geemus commented Dec 30, 2013

Yeah, unusual to say the least.

@rgbkrk
Copy link

rgbkrk commented Dec 31, 2013

Thanks for that @Kami. Just updated the two PRs I put in on repos I've used or affect users of Ansible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Digital Ocean API is not told to scrub (securely delete) VM on destroy

5 participants