Allow validateInclusions to handle case-insensitive file systems.#8
Draft
yuzhy8701 wants to merge 1 commit intofmeum:28803-inclusion-checkfrom
Draft
Allow validateInclusions to handle case-insensitive file systems.#8yuzhy8701 wants to merge 1 commit intofmeum:28803-inclusion-checkfrom
validateInclusions to handle case-insensitive file systems.#8yuzhy8701 wants to merge 1 commit intofmeum:28803-inclusion-checkfrom
Conversation
The include validation now uses a `TreeMap` with case-insensitive path comparison on Windows to correctly identify allowed includes. The logic is also restructured to first collect all potentially undeclared inputs and then remove those that are explicitly allowed, to reduce memory impacts.
2 tasks
|
Thank you for contributing to the Bazel repository! This pull request has been marked as stale since it has not had any activity in the last 30 days. It will be closed in the next 30 days unless any other activity occurs. If you think this PR is still relevant and should stay open, please post any comment here and the PR will no longer be marked as stale. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The include validation now uses a
TreeMapwith case-insensitive path comparison on Windows to correctly identify allowed includes. The logic is also restructured to first collect all potentially undeclared inputs and then remove those that are explicitly allowed, to reduce memory impacts.