Skip to content
This repository was archived by the owner on Dec 17, 2023. It is now read-only.
This repository was archived by the owner on Dec 17, 2023. It is now read-only.

Would you consider typeshed? #8

Closed

Description

@Avasam

Hello!
I am going through stub packages in https://github.com/microsoft/python-type-stubs to remove obsolete ones, upstream some, and move the rest that I can over to https://github.com/python/typeshed .

https://github.com/microsoft/python-type-stubs/tree/main/networkx is bundled with Pylance, and any outdated stubs on there simply hurt Pylance users, so I've been helping move things along. The long-term goals of the maintainers there is to upstream everything to the base repos or typeshed.

Given networkx/networkx#3988 and networkx/networkx#4014, I don't think that networkx will ship their own stubs (or inline typing) anytime soon.

Since you've already got some stubs started, I've been wondering if you'd like to migrate them over to typeshed? Some advantages includes a well-developped developper toolkit, lots of testing and type validations, as well as review by Python Typing experts. On top of that, pyright comes bundled with types from typeshed and mypy automatically recommends installing them.

Activity

  1. fmagin commented on Jul 7, 2023

    @fmagin
    Owner

    Sorry, I had thought I had replied to you already, but I just realized I didn't.
    @rhelmot also suggested this when I talked to her, and she has experience with the relevant processes and tooling already.

    @rhelmot: Did you have any time to look into it so far?

  2. fmagin commented on Dec 17, 2023

    @fmagin
    Owner

    This repo is now been merged into typeshed, thanks to everyone involved!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions