Properly mitigate CVE-2024-53920 on Emacs 30+#2160
Open
bbatsov wants to merge 1 commit into
Open
Conversation
On Emacs 30+, disable the emacs-lisp checker for files not marked as trusted via `trusted-content`. Byte-compilation triggers macro expansion which can execute arbitrary code, so the previous mitigation (disabling `enable-local-eval`) was insufficient.
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On Emacs 30+, disable the
emacs-lispchecker for files not marked as trusted viatrusted-content. Byte-compilation triggers macro expansion which can execute arbitrary code, so the previous mitigation (disablingenable-local-eval) was insufficient — it only blocked one attack vector.Users need to add their project directories to
trusted-contentfor the checker to work on Emacs 30+.Fixes #2159