auth/gcp: add support for sovereign cloud artifact registry#1201
Conversation
Signed-off-by: Matheus Pimenta <[email protected]>
|
Successfully created backport PR for |
|
Hello Matheus, I should have been more specific. Container images on s3ns are formatted this way : Contrary to gcp, there is no prefix with the location. "u-france-east1" doesn't show up on image name. i think regexp should be change to: const registryPattern = `^(((.+\.)?gcr\.io)|(.+-docker\.pkg\.dev)|(docker\.s3nsregistry\.fr))$`I'm sorry I believe this change affect unit tests too. Thank you in advance! |
|
Hello @matheuscscp , I was yesterday @ google cloud summit france. I met the S3NS team and shared your link with them. They agreed with me, this is an error in the documentation. I share with you two screenshots, one from S3NS and one from GCP.
If this is not enough so that you trust me, I can share with you the result of docker push commands. To sum up, it is necessary to necessary to remove "u-france-east1-" from the regexp. Thank you in advance! |


Closes: fluxcd/flux2#5874
This will unblock support only for controller-level workload identity. The Google libraries will read the environment variables internally when using controller-level workload identity. For object-level we will need new API surface, to be covered in a new RFC I'm working on.