apis: Add Artifact type to meta package#1018
Merged
Merged
Conversation
Signed-off-by: Stefan Prodan <[email protected]>
souleb
reviewed
Sep 3, 2025
| // the file in the root of the Artifact storage on the local file system of | ||
| // the controller managing the Source. | ||
| // +required | ||
| Path string `json:"path"` |
Member
There was a problem hiding this comment.
Should this be an optional field? Kustomize controller uses spec.Path to find the manifests once the archive is uncompressed as far as I know.
Member
Author
There was a problem hiding this comment.
I'm not for making this optional, this is used by the storage GC, so it's a requirement of the internals of source-controller but not consumers. kustomize and helm-controller use the URL field only.
Member
There was a problem hiding this comment.
status:
artifact:
digest: sha256:edb4266e6f0a6ea1f00bdb882f2fcb8d9c2829f60d2a70c1f1bb1ec972649d5a
lastUpdateTime: "2025-08-06T09:56:37Z"
metadata:
org.opencontainers.image.created: "2025-07-14T10:03:53Z"
org.opencontainers.image.revision: refs/heads/main@sha1:abedb77c208ddac5f12cda9ab055451e31637f96
org.opencontainers.image.source: https://github.com/matheuscscp/gitops-playground
path: ocirepository/flux-system/flux-system/sha256:dba3d2e4782bea12da7ffd4197bbf0c9db55bc0ae62e266a97a031f87eb3231e.tar.gz
revision: latest@sha256:dba3d2e4782bea12da7ffd4197bbf0c9db55bc0ae62e266a97a031f87eb3231e
size: 7100
url: http://source-controller.flux-system.svc.cluster.local./ocirepository/flux-system/flux-system/sha256:dba3d2e4782bea12da7ffd4197bbf0c9db55bc0ae62e266a97a031f87eb3231e.tar.gzHere, Path is a path to the artifact in the artifact storage. The field .spec.path is a path inside the artifact.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extract the
Artifacttype from source-controller API intofluxcd/apis/meta. This is a prerequisite for RFC-0012.PS. The only change I made to the
Artifacttype is to make theDigesta required field, this was suppose to happen at GA time (source-controller v1.0.0) but we missed it.