Skip to content

Fix nil pointer deref during diff attempt#672

Merged
hiddeco merged 1 commit intomainfrom
fix-drift-nil-deref
Apr 12, 2023
Merged

Fix nil pointer deref during diff attempt#672
hiddeco merged 1 commit intomainfrom
fix-drift-nil-deref

Conversation

@hiddeco
Copy link
Copy Markdown
Member

@hiddeco hiddeco commented Apr 12, 2023

Fixes #669
Fixes #671

@hiddeco hiddeco added the bug Something isn't working label Apr 12, 2023
Copy link
Copy Markdown
Member

@stefanprodan stefanprodan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks @hiddeco 🥇

@hiddeco hiddeco force-pushed the fix-drift-nil-deref branch from 7a77c16 to 32b5d7e Compare April 12, 2023 09:41
@hiddeco hiddeco added the area/drift Drift detection/correction related issues and pull requests label Apr 12, 2023
@hiddeco hiddeco merged commit 96a17ef into main Apr 12, 2023
@hiddeco hiddeco deleted the fix-drift-nil-deref branch April 12, 2023 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/drift Drift detection/correction related issues and pull requests bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

nil pointer deref during reconciliation with drift detection enabled Drift detection fails with invalid memory address on HelmRelease renaming

2 participants