Use ShortenName for release name in Test action#1492
Merged
Conversation
matheuscscp
added
bug
matheuscscp
approved these changes
May 19, 2026
matheuscscp
left a comment
matheuscscp
left a comment
Member
There was a problem hiding this comment.
LGTM
@SebTardif Please rebase and force-push 🙏
Install and Upgrade both call release.ShortenName(obj.GetReleaseName()) before passing the name to Helm, but Test passes the raw unshorteened name. When GetReleaseName() returns a composed name (TargetNamespace + Name) that exceeds 53 characters, ShortenName hashes it. The Test action then looks up the release by the full unhashed name, causing a lookup miss and a silent test failure. Signed-off-by: Sebastien Tardif <[email protected]>
SebTardif
force-pushed
the
fix/test-release-name-shorten
branch
from
b66f2b1 to
6d3f888
Compare
Contributor
Author
|
Rebased onto main and force-pushed. Thanks for the review. |
Member
|
Successfully created backport PR for |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
action.Test()passesobj.GetReleaseName()directly totest.Run()without callingrelease.ShortenName(). Install and Upgrade both userelease.ShortenName()to hash release names that exceed 53 characters. The Test action uses the full unhashed name, causing a lookup miss for long release names.Closes #1489
Changes
One-line change: wrap
obj.GetReleaseName()withrelease.ShortenName()intest.go:44, and add thereleaseimport.Verification
go build ./...passesgo vet ./...passes