Skip to content

[Bug] helm-controller v1.5.0 manifest rendering whitespace incorrectly #1423

Description

@iAnomaly

Hi Flux team,

After upgrading to Flux v2.8.0 (containing helm-controller v1.5.0) our HelmRelease has started failing with:

Helm install failed for release foo-system/foo with chart [email protected]+c494f9f11838: error merging manifests: parsing foo/templates/rbac.yaml: invalid document separator: ---apiVersion: v1

This stops when reverting to Flux < v2.8.0 (helm-controller v1.4.x) and I cannot reproduce with helm template or helm upgrade (Helm v4.1.0).

If I had to speculate this looks like maybe you started dropping/trimming the comments Helm adds between manifests to save bytes/space but are erroneously clipping the last newline? I.e. output should look like:

...
---
apiVersion: v1
...

not

...
---apiVersion: v1
...

Happy to provide more details as needed.

Thank you for all your work and continued support for Flux!

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    No type

    Fields

    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions